Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support descriptions for azuread_application_password / azuread_service_principal_password #253

Merged
merged 6 commits into from
May 27, 2020

Conversation

manicminer
Copy link
Contributor

@manicminer manicminer commented May 19, 2020

This is the same description field yielded by the corresponding Portal page. Although the API exposes it as customKeyIdentifier this term doesn't seem to be exposed to users.

Fixes: #95

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 - however maybe we want to include in the docs that this is mapped to the custome identifier SDK/API property?

@katbyte katbyte added this to the v0.10.0 milestone May 24, 2020
@manicminer
Copy link
Contributor Author

Cool, I wasn't sure about that, thanks @katbyte! Have added.

@manicminer
Copy link
Contributor Author

Tests pass

Screenshot 2020-05-27 04 11 56
Screenshot 2020-05-27 04 12 08

@manicminer manicminer merged commit 743c175 into master May 27, 2020
manicminer added a commit that referenced this pull request May 27, 2020
@ghost
Copy link

ghost commented Jun 5, 2020

This has been released in version 0.10.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azuread" {
    version = "~> 0.10.0"
}
# ... other configuration ...

@manicminer manicminer deleted the app-password/description branch June 8, 2020 15:36
@ghost
Copy link

ghost commented Jun 26, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Jun 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resource for Azure_application_Client secrets
2 participants