Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azuread_group: add mail_enabled and security_enabled attributes #393

Merged
merged 2 commits into from
Feb 8, 2021

Conversation

manicminer
Copy link
Contributor

Adds mail_enabled and security_enabled to the resource and data source. Due to API limitations, only security groups can be created, so these are computed for now.

Closes: #391

@manicminer
Copy link
Contributor Author

Test results

Screenshot 2021-02-05 at 16 40 26

@manicminer manicminer requested a review from a team February 5, 2021 16:40
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@manicminer
Copy link
Contributor Author

@katbyte Thanks!

@manicminer manicminer merged commit d95c7a2 into main Feb 8, 2021
@manicminer manicminer deleted the feature/group-mail-security branch February 8, 2021 20:39
manicminer added a commit that referenced this pull request Feb 8, 2021
@ghost
Copy link

ghost commented Feb 18, 2021

This has been released in version 1.4.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azuread" {
    version = "~> 1.4.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Mar 11, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Mar 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

data source azuread_group needs to filter by type
2 participants