Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App registration should accept on_premise_security_identifier as additional property #462

Closed
dvdvorle opened this issue Jun 15, 2021 · 1 comment · Fixed by #474
Closed

Comments

@dvdvorle
Copy link

dvdvorle commented Jun 15, 2021

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritise this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritise the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Terraform (and AzureAD Provider) Version

Affected Resource(s)

Terraform v1.0.0
on windows_amd64
+ provider registry.terraform.io/hashicorp/azuread v1.5.1

Terraform Configuration Files

resource "azuread_application" "application" {
  display_name            = var.name
  group_membership_claims = "SecurityGroup"

  # Onderstaande is niet mogelijk omdat de property on_premise_security_identifier niet ondersteund wordt.
  # Daarom hieronder maar met een script

  optional_claims {
    access_token {
      name                  = "groups"
      source                = null
      essential             = false
      additional_properties = ["on_premise_security_identifier", "emit_as_roles"]
    }
  }
}

Expected Behavior

In portal terms:
image

In app registration manifest terms:

{
    ... snip ...
    "optionalClaims": {
        "accessToken": [
	    {
	        "additionalProperties": [
		    "on_premise_security_identifier",
		    "emit_as_roles"
		],
		"essential": false,
		"name": "groups",
		"source": null
	    }
    ]
    ... snip ...
}

Actual Behavior

│ Error: expected optional_claims.0.access_token.0.additional_properties.0 to be one of [dns_domain_and_sam_account_name emit_as_roles include_externally_authenticated_upn include_externally_authenticated_upn_without_hash netbios_domain_and_sam_account_name sam_account_name use_guid], got on_premise_security_identifier

Steps to Reproduce

  1. terraform apply
@dvdvorle dvdvorle changed the title App registration doesn't accept on_premise_security_identifier as additional property App registration should accept on_premise_security_identifier as additional property Jun 15, 2021
@manicminer manicminer added this to the v2.0.0 milestone Jun 16, 2021
@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants