Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for OIDC Authentication #805

Merged
merged 3 commits into from
Jun 8, 2022
Merged

Support for OIDC Authentication #805

merged 3 commits into from
Jun 8, 2022

Conversation

SudoSpartanDan
Copy link
Contributor

Closes #803

@manicminer here's the implementation for the AzureAD provider. https://github.com/manicminer/hamilton/releases/tag/v0.40.0 added this capability for the authentication method

@manicminer manicminer self-requested a review June 1, 2022 15:37
@manicminer manicminer added this to the v2.23.0 milestone Jun 6, 2022
manicminer
manicminer suggested changes Jun 6, 2022
View reviewed changes
Copy link
Contributor

@manicminer manicminer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @SudoSpartanDan! Sorry for the delayed review, I've been away and catching up. I spotted a couple of minor things in the docs, this otherwise looks great. If you can look at the suggested changes then this should be good to merge for a release this week. Thanks again!

docs/guides/managed_service_identity.md Show resolved Hide resolved
docs/index.md Outdated Show resolved Hide resolved
SudoSpartanDan and others added 2 commits June 8, 2022 06:39
@SudoSpartanDan @manicminer
Update docs/guides/managed_service_identity.md
7341455 
Co-authored-by: Tom Bamford <tom@bamford.io>
@SudoSpartanDan @manicminer
Update docs/index.md
865431b 
Co-authored-by: Tom Bamford <tom@bamford.io>
@SudoSpartanDan
Copy link
Contributor Author

@manicminer No worries and thanks for reviewing! Updated based on your changes!

manicminer
manicminer approved these changes Jun 8, 2022
View reviewed changes
Copy link
Contributor

@manicminer manicminer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SudoSpartanDan Thanks for making the changes, this LGTM!

@manicminer manicminer merged commit dbca12e into hashicorp:main Jun 8, 2022
manicminer added a commit that referenced this pull request Jun 8, 2022
@manicminer
Changelog for #805
caf17a6
@github-actions
Copy link

This functionality has been released in v2.23.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@etiennetremel etiennetremel mentioned this pull request Jun 10, 2022
Closed
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@manicminer manicminer manicminer approved these changes

Assignees
No one assigned
Labels
authentication enhancement size/L
Projects
None yet
Milestone
v2.23.0
Development

Successfully merging this pull request may close these issues.

Support for OIDC Authentication
2 participants
@SudoSpartanDan @manicminer