Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed overly restrictive validation for federated cred audience vals #808

Merged
merged 1 commit into from
Jun 1, 2022

Conversation

JustinJudd
Copy link
Contributor

Current audicence field parsing validates that the values are URIs. This is not a requirement for audience fields though. JWT spec allows these to be URIs or strings (https://datatracker.ietf.org/doc/html/rfc7519#section-4.1.3)

Copy link
Contributor

@manicminer manicminer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this fix @JustinJudd!

@manicminer manicminer merged commit 11cb53d into hashicorp:main Jun 1, 2022
manicminer added a commit that referenced this pull request Jun 1, 2022
@github-actions
Copy link

This functionality has been released in v2.23.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants