Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: MSI support for APP Service #1106

Closed
pixelicous opened this issue Apr 10, 2018 · 11 comments
Closed

Feature request: MSI support for APP Service #1106

pixelicous opened this issue Apr 10, 2018 · 11 comments

Comments

@pixelicous
Copy link

Hi,

I see that MSI support is slowly being added to resources.
Is it possible to also add it to an app service?

Thank you.

@metacpp
Copy link
Contributor

metacpp commented Apr 10, 2018

@pixelicous what's the scenario of using MSI ? Is this for the authentication for Terraform to provision resource ?

If you want to use Terraform with MSI on Azure VM, you probably can try this:
https://azure.microsoft.com/en-us/blog/announcing-terraform-availability-in-the-azure-marketplace/

And MSI support for App Service is supported now:
https://docs.microsoft.com/en-us/azure/active-directory/managed-service-identity/overview

@tombuildsstuff
Copy link
Contributor

@metacpp heads up that this feature request is to support MSI within App Services as we do for other resources, such as Virtual Machines. Support for this is available in the SDK here :)

@pixelicous
Copy link
Author

pixelicous commented Apr 10, 2018

@metacpp @tombuildsstuff we provision app services through terraform, today the only reason we need to call an arm template is to set https and add msi, https will be supported on 1.3. 3 but msi still not.. Adding the ability to bind ssl to "custom domain" would be amazing too but currenty referencing certificate in tf is broken anyways

Thx guys!

@simongh
Copy link
Contributor

simongh commented Apr 11, 2018

I'm using a provisioner script to switch on MSI for my app service, but when I do, it kills TF - you can't do anything with the resource, even if you switch MSI off again. Hoping the latest release will fix this as I'm stuck using 1.0.1 - the last release that worked with MSI, but actual support for MSI would be most welcome.

@Phydeauxman
Copy link

Any update on when this will get incorporated? Just wondering if I should press forward with doing an ARM template for it or wait (if it is relatively soon).

@tombuildsstuff
Copy link
Contributor

@simongh v1.3.3 includes a version of the Azure SDK for Go with the correct schema used for MSI - as such you should be able to upgrade to this now, I believe?

@Phydeauxman

Any update on when this will get incorporated? Just wondering if I should press forward with doing an ARM template for it or wait (if it is relatively soon).

Support for MSI in App Services is being added in #1130 - I missed the notification that changes were pushed, but we'll take another look shortly.

Thanks!

@tombuildsstuff tombuildsstuff added this to the 1.5.0 milestone Apr 27, 2018
@tombuildsstuff
Copy link
Contributor

Fixed via #1130

@pixelicous
Copy link
Author

@tombuildsstuff great stuff! thanks! Hopefully the dreadful #894 would be gone next release too 😁 I Actually there is another networking matter i should open a ticket for, long ago i tested detaching and reattaching NSGs and it didn't play nice, i need to run a test and send the output, just not too much time on my hands

@katbyte
Copy link
Collaborator

katbyte commented May 14, 2018

Hello @pixelicous,

We have just released v1.5.0 of the provider that includes this fix 🙂

@pixelicous
Copy link
Author

@katbyte ive been updated! thanks! :) will test soon

@ghost
Copy link

ghost commented Mar 31, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants