Fix #105 detect missing subnet properties #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bnets if they're missing from the Azure API response.
tombuildsstuff
approved these changes
Jun 22, 2017
There was a problem hiding this comment.
Hi @cchildress
Thanks for this PR - this LGTM and the tests pass:
$ TF_ACC=1 envchain azurerm go test ./azurerm -v -run TestAccAzureRMSubnet -timeout 300m -parallel 5
=== RUN TestAccAzureRMSubnet_importBasic
--- PASS: TestAccAzureRMSubnet_importBasic (136.29s)
=== RUN TestAccAzureRMSubnet_importWithRouteTable
--- PASS: TestAccAzureRMSubnet_importWithRouteTable (142.40s)
=== RUN TestAccAzureRMSubnet_basic
--- PASS: TestAccAzureRMSubnet_basic (144.70s)
=== RUN TestAccAzureRMSubnet_routeTableUpdate
--- PASS: TestAccAzureRMSubnet_routeTableUpdate (168.59s)
=== RUN TestAccAzureRMSubnet_disappears
--- PASS: TestAccAzureRMSubnet_disappears (118.39s)
PASS
ok github.com/terraform-providers/terraform-provider-azurerm/azurerm 710.395s
Thanks!
tombuildsstuff
added a commit
that referenced
this pull request
Jun 22, 2017
tombuildsstuff
added a commit
that referenced
this pull request
Jul 4, 2017
Fix #105 detect missing subnet properties
tombuildsstuff
added a commit
that referenced
this pull request
Jul 4, 2017
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#105
We should catch missing security group and route table entries for subnets if they're missing from the Azure API response. This sets both to an empty string in the read function if no result was returned from the Azure API.