Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Azure Front Door Standard/Premium #11983

Closed
AONunan opened this issue May 27, 2021 · 8 comments · Fixed by #16671
Closed

Support for Azure Front Door Standard/Premium #11983

AONunan opened this issue May 27, 2021 · 8 comments · Fixed by #16671

Comments

@AONunan
Copy link
Contributor

AONunan commented May 27, 2021

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Would it be possible to add support for Azure Front Door Standard/Premium?

I manually deployed this resource in the Azure Portal to see what the underlying components are. Unlike the original Front Door resource which is deployed as type "Microsoft.Network/frontdoors", the following resource types are deployed for Front Door Premium:

  • Microsoft.Cdn/Profiles
  • Microsoft.Cdn/Profiles/AfdEndpoints
  • Microsoft.Cdn/Profiles/AfdEndpoints/Routes
  • Microsoft.Cdn/Profiles/OriginGroups
  • Microsoft.Cdn/Profiles/OriginGroups/Origins

Terraform already supports azurerm_cdn_profile. However, this Front Door Premium resource is deployed with a SKU of Premium_AzureFrontDoor, which is not allowed currently in the "azurerm_cdn_profile" resource:

Error: expected sku to be one of [Standard_Akamai Standard_ChinaCdn Standard_Verizon Standard_Microsoft Premium_Verizon], got Premium_AzureFrontDoor

New or Affected Resource(s)

  • azurerm_cdn_profile

Potential Terraform Configuration

resource "azurerm_cdn_profile" "example" {
  name                = "exampleFrontDoorPremium"
  location            = "West US"
  resource_group_name = azurerm_resource_group.example.name
  sku                 = "Premium_AzureFrontDoor"

  origin_group {
    # Origin group config here
  }

  afd_endpoint {
    # Azure Front Door Endpoint config here
  }
}

References

@WodansSon
Copy link
Collaborator

@AONunan, thank you for opening this issue. This resource has not yet been implemented for Terraform as of yet and is not backward compatible with the existing front door resource. Frontdoor X will be implemented in the near future. 🚀

@dschniepp
Copy link
Contributor

dschniepp commented Aug 7, 2021

@WodansSon are there any plans around the structure? I would like to see that the sub resources are not nested inside the root resource or at least to have two options like we have for azurerm_virtual_network. This would enable us to create more advanced setups where we are able to split the definition across modules so multiple teams can utilize the same frontdoor so they can add the routing as they need. Thanks

@BenWaller
Copy link

Are there any plans to continue with this now that the new Front Door is GA? https://azure.microsoft.com/en-us/blog/introducing-the-new-azure-front-door-reimagined-for-modern-apps-and-content/

@sebader
Copy link
Contributor

sebader commented Mar 31, 2022

@BenWaller the PR that's linked above is still in active WIP

@tombuildsstuff
Copy link
Contributor

Initial support for this (Profiles/Endpoints) shipped in v3.9.0 - the remaining resources will be split out of #16671 then split/refactored as appropriate - however since the initial resources for this have shipped, I'm going to close this issue for the moment.

@sebader
Copy link
Contributor

sebader commented Jun 3, 2022

well, to be honest, with only the profile and endpoint resources, you don't really get anywhere in deploying an AFD Standard/Premium. So hopefully the remaining resources will follow soon :)

@tombuildsstuff
Copy link
Contributor

@sebader indeed, although this issue is technically tracking support for the new SKU's, there's another issue tracking Firewall Policies etc - so I've left that one open as that's still pending. The other resources are being split out/refactored as we speak :)

@github-actions
Copy link

github-actions bot commented Jul 4, 2022

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.