-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix to not drop MySQL and PostgreSQL DB when storage_mb value is changed #1532
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Simple change. LGTM
@jeffreyCline can you run all of the Postgres/MySQL tests for this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once the docs issue is fixed this otherwise LGTM 👍🏼
@@ -138,7 +138,6 @@ func resourceArmPostgreSQLServer() *schema.Resource { | |||
"storage_mb": { | |||
Type: schema.TypeInt, | |||
Required: true, | |||
ForceNew: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we update the docs to mention that this is no longer ForceNew? (And above)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I thought about that after I did the initial push. I'll update those now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just looked at the documentation and the original text does not mention that it will ForceNew so I believe this is a no op:
storage_mb
- (Required) Max storage allowed for a server. Possible values are between5120
MB(5GB) and1048576
MB(1TB) for the Basic SKU and between5120
MB(5GB) and4194304
MB(4TB) for General Purpose/Memory Optimized SKUs. For more information see the product documentation.
@tombuildsstuff I am running them now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @jeffreyCline,
Outside the docs requiring an update this LGTM 👍
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
Fixes issue #1522
Test Results
(fixes #1522 )