azurerm_virtual_hub - support for virtual_router_asn and virtual_router_ips properties #15741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
successful deployment and output of newly added computed params |
katbyte
requested changes
Mar 10, 2022
There was a problem hiding this comment.
Thanks @jakubpech - overall looks good, but could we add these properties to a test ?
|
@katbyte new properties added to tests |
stephybun
requested changes
Mar 15, 2022
There was a problem hiding this comment.
Thanks for this PR @jakubpech. I left some suggestions and we also have some test failures.
------- Stdout: -------
=== RUN TestAccVirtualHub_basic
=== PAUSE TestAccVirtualHub_basic
=== CONT TestAccVirtualHub_basic
testcase.go:110: Step 1/2 error: Check failed: Check 3/3 error: azurerm_virtual_hub.test: Attribute 'virtual_router_ips' expected to be set
--- FAIL: TestAccVirtualHub_basic (1682.11s)
FAIL
------- Stdout: -------
=== RUN TestAccDataSourceAzureRMVirtualHub_basic
=== PAUSE TestAccDataSourceAzureRMVirtualHub_basic
=== CONT TestAccDataSourceAzureRMVirtualHub_basic
testcase.go:110: Step 1/1 error: Check failed: Check 4/4 error: data.azurerm_virtual_hub.test: Attribute 'virtual_router_ips' expected to be set
--- FAIL: TestAccDataSourceAzureRMVirtualHub_basic (1849.56s)
FAIL
Co-authored-by: stephybun <steph@hashicorp.com>
|
All requested changes are processed and fmt is fixed. I'm still a bit struggling with running the azurerm acceptance tests from my work windows laptop. I guess some permission issues :( But it builds ok, runs as expected and all checks have passed on GitHub. |
katbyte
changed the title
katbyte
approved these changes
Mar 22, 2022
|
This functionality has been released in v3.0.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables deployments of managed NVA appliances (like VMware SD-WAN, Meraki VMX) to Azure Virtual WAN hub.
PR adds two new computed parameters to virtual_hub resource/datasource, which are required for the network integration:
"virtual_router_asn"
"virtual_router_ips"
PR addresses GH issue #13427, where the managed NVA application's read function returns an empty parameter 'tags' of the type map[string]interface{} which is not supported in the current code. To make this clear, these are not resource-level tags, but tags inside of the "parameters" parameter.
I do not see an easy way how to add support of nested tags to the "parameters" schema without making breaking changes so I've at least hot-fixed the problem when the 'tags' are returned but are empty. If the tags will not be empty, the error will be returned as before.
Tested NVA appliances do not use the tags.