Data Source for Azure Container Registry

[schoren]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

There is currently no data source for ACR resources. In our case, we share a single ACR instance among several projects, and it would be nice to be able to reference it. The current workaround is to inject the ACR resource ID as a terraform variable.

New or Affected Resource(s)

• azurerm_container_registry

Potential Terraform Configuration

data "azurerm_container_registry" "test" {
  name = "myregistry"
  resource_group_name = "my-resource-group"
}

[schoren]

I have created the PR #1642 that fixes this issue. However, I cannot get the tests to work. I always get the same message:
testing.go:513: Step 0 error: After applying this step, the plan was not empty:

Can anyone point me in the right direction?

[tombuildsstuff]

@schoren

I have created the PR #1642 that fixes this issue. However, I cannot get the tests to work. I always get the same message:

testing.go:513: Step 0 error: After applying this step, the plan was not empty:

Firstly, thanks for this PR :)

I've left comments in the PR in question - but the errors you're seeing in the tests are because the fields being set via d.Set() are missing from the Schema (fields need to be present in the Schema if they're set, or they don't get persisted/can't be accessed) - so once there's matching fields in the schema the tests should pass (and we should be able to merge this 😄)

Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!