Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_application_gateway - data source - add backend_address_pool attribute #19026

Merged
merged 2 commits into from
Oct 31, 2022

Conversation

torrick
Copy link
Contributor

@torrick torrick commented Oct 27, 2022

Updated the azurerm_application_gateway datasource to expose the backend_address_pool configuration as a list to enable adding targets to backend pools in different terraform projects.

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @torrick - looks like we have a test failure

------- Stdout: -------
=== RUN   TestAccDataSourceAppGateway_backendAddressPool
=== PAUSE TestAccDataSourceAppGateway_backendAddressPool
=== CONT  TestAccDataSourceAppGateway_backendAddressPool
    testcase.go:110: Step 1/1 error: Check failed: Check 1/3 error: data.azurerm_application_gateway.test: Attribute 'backend_address_pool.0.#' not found
--- FAIL: TestAccDataSourceAppGateway_backendAddressPool (1273.32s)
FAIL

@torrick
Copy link
Contributor Author

torrick commented Oct 28, 2022

Thanks @katbyte -- that was a bit of a weird one. Test passed locally but it wasn't really an assertion I think I needed anyway.

@torrick torrick requested a review from katbyte October 28, 2022 13:23
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

THanks @torrick - LGTM 🎃

@katbyte katbyte merged commit 42fdfb2 into hashicorp:main Oct 31, 2022
katbyte added a commit that referenced this pull request Oct 31, 2022
@github-actions github-actions bot added this to the v3.30.0 milestone Oct 31, 2022
@github-actions
Copy link

github-actions bot commented Nov 4, 2022

This functionality has been released in v3.30.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Dec 5, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants