-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
azurerm_cosmosdb_account
: Fix issue about enabling analytical storage for CosmosDB is forcing re-creation
#19659
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this @sinbai, still need to update the docs but otherwise this is good to go 👍
Thanks for your feedback @stephybun , I have updated the doc, could you please take another look and feel free to let me know your suggestions? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @sinbai LGTM 👍
This functionality has been released in v3.36.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
…age for CosmosDB is forcing re-creation (hashicorp#19659) * fix issue 19630 * update code * update code * update code
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Currently, since
analytical_storage_enabled
is aForceNew
property, theazurerm_cosmosdb_account
is recreated when its value changes.In fact,
analytical_storage_enabled
could be enabled when it is disabled, but it could not be disabled after it is enabled. So submitting this PR just setsForceNew
to true when its value changes from true to false.Fix #19630.
Test Results:
PASS: TestAccCosmosDBAccount_analyticalStorage (1818.29s)