Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Batch data plane: switching to use tombuildsstuff/kermit / updating to API Version 2022-01-01.15.0 #21234

Merged
merged 2 commits into from
Mar 31, 2023

Conversation

tombuildsstuff
Copy link
Contributor

Whilst validating a PR for Kermit, I noticed that the Batch Data Plane API is available in Kermit but hasn't yet been moved over, so this PR:

  1. Switches the Batch Data Plane SDK to use tombuildsstuff/kermit rather than Azure/azure-sdk-for-go
  2. Updates to using API Version 2022-01-01.15.0

@tombuildsstuff
Copy link
Contributor Author

Tests pass:

Screenshot 2023-03-31 at 15 50 12

Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mbfrahry mbfrahry merged commit 1b40a61 into main Mar 31, 2023
@mbfrahry mbfrahry deleted the refactor/batch-data-plane-to-kermit branch March 31, 2023 15:43
mbfrahry added a commit that referenced this pull request Mar 31, 2023
tombuildsstuff added a commit that referenced this pull request Apr 3, 2023
@github-actions
Copy link

This functionality has been released in v3.51.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants