Timezone parameter missing on azurerm_recovery_services_protection_policy_vm

[AndreasMWalter]

First of all, thank you for adding the resource!

As I have already posted, Azure requires the timezone to be specified, it would help alot if it can be implemented in the resource.

Originally posted by @AndreasMWalter in #1978 (comment)

[katbyte]

Hi @AndreasMWalter,

The resource will work without the timezone specified, all the portal does is change the time provided to UTC based on the zone.

The documentation needs to be updated and we could add a timezone parameter to the resource, however its not required so is not a high priority at the moment.

[AndreasMWalter]

I would expect it to do more than just change the time provided, e.g. respect DST changes (Expect: Since they have implemented this for Azure automation), we shall know on monday since DST change will be on Sunday in Europe. However a policy that was configured for 9:30 CET UTC+1 just successfully started a backup at 9:30 CEST UTC+2

Even though I do despise people who still have not committed to use UTC, some customers will still want this feature.

Also when I say "we shall know", I mean a colleague of mine since I am switching employers end of this month and will not be in the office on monday, and my Azure account should be blocked then...

[katbyte]

@AndreasMWalter,

I would expect it to do more to, however the backend API does not have a timezone option, and the portal simply converts it into UTC and sends that off to the API.

Here is what is exposed to us via the SDK/API 🙁

type SimpleSchedulePolicy struct {
	// ScheduleRunFrequency - Defines the frequency interval (daily or weekly) for the schedule policy. Possible values include: 'ScheduleRunTypeInvalid', 'ScheduleRunTypeDaily', 'ScheduleRunTypeWeekly'
	ScheduleRunFrequency ScheduleRunType `json:"scheduleRunFrequency,omitempty"`
	// ScheduleRunDays - This list is the days of the week when the schedule runs.
	ScheduleRunDays *[]DayOfWeek `json:"scheduleRunDays,omitempty"`
	// ScheduleRunTimes - List of times, during a day, when the schedule runs.
	ScheduleRunTimes *[]date.Time `json:"scheduleRunTimes,omitempty"`
	// ScheduleWeeklyFrequency - The number of times per week the schedule runs.
	ScheduleWeeklyFrequency *int32 `json:"scheduleWeeklyFrequency,omitempty"`
	// SchedulePolicyType - Possible values include: 'SchedulePolicyTypeSchedulePolicy', 'SchedulePolicyTypeLongTermSchedulePolicy', 'SchedulePolicyTypeSimpleSchedulePolicy'
	SchedulePolicyType SchedulePolicyType `json:"schedulePolicyType,omitempty"`
}

[AndreasMWalter]

@katbyte Sorry I am no Go expert, but since I found it in the REST / .NET API/SDK I thought it might be this one?

type AzureIaaSVMProtectionPolicy struct {
    // SchedulePolicy - Backup schedule specified as part of backup policy.
    SchedulePolicy BasicSchedulePolicy `json:"schedulePolicy,omitempty"`
    // RetentionPolicy - Retention policy with the details on backup copy retention ranges.
    RetentionPolicy BasicRetentionPolicy `json:"retentionPolicy,omitempty"`
    // InstantRpRetentionRangeInDays - Instant RP retention policy range in days
    InstantRpRetentionRangeInDays *int32 `json:"instantRpRetentionRangeInDays,omitempty"`
    // TimeZone - TimeZone optional input as string. For example: TimeZone = "Pacific Standard Time".
    TimeZone *string `json:"timeZone,omitempty"`
    // ProtectedItemsCount - Number of items associated with this policy.
    ProtectedItemsCount *int32 `json:"protectedItemsCount,omitempty"`
    // BackupManagementType - Possible values include: 'BackupManagementTypeProtectionPolicy', 'BackupManagementTypeAzureStorage', 'BackupManagementTypeAzureIaasVM', 'BackupManagementTypeAzureSQL', 'BackupManagementTypeAzureWorkload', 'BackupManagementTypeGenericProtectionPolicy', 'BackupManagementTypeMAB'
    BackupManagementType ManagementTypeBasicProtectionPolicy `json:"backupManagementType,omitempty"`
}

https://godoc.org/github.com/Azure/azure-sdk-for-go/services/recoveryservices/mgmt/2017-07-01/backup

[katbyte]

Thank you @AndreasMWalter!

Good find, we are currently using the 2016-06-1 whitch doesn't have that property:

// AzureIaaSVMProtectionPolicy azure VM (also known as IaaS VM) workload-specific backup policy.
type AzureIaaSVMProtectionPolicy struct {
	// SchedulePolicy - The backup schedule specified as part of backup policy.
	SchedulePolicy BasicSchedulePolicy `json:"schedulePolicy,omitempty"`
	// RetentionPolicy - The retention policy with the details on backup copy retention ranges.
	RetentionPolicy BasicRetentionPolicy `json:"retentionPolicy,omitempty"`
	// ProtectedItemsCount - The number of items associated with this policy.
	ProtectedItemsCount *int32 `json:"protectedItemsCount,omitempty"`
	// BackupManagementType - Possible values include: 'BackupManagementTypeProtectionPolicy', 'BackupManagementTypeAzureIaasVM', 'BackupManagementTypeMAB', 'BackupManagementTypeAzureSQL'
	BackupManagementType ManagementTypeBasicProtectionPolicy `json:"backupManagementType,omitempty"`
}

I'll give upgrading the API version we are using a go and see if it works 🙂

[katbyte]

@AndreasMWalter,

I have added the timezone parameter in #2404 🙂

[AndreasMWalter]

@AndreasMWalter,

I have added the timezone parameter in #2404 🙂

Cheers! I will inform my ex-colleagues, so they can continue their testing.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!