Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azurerm_synapse_firewall_rule: fix rule name regex #22571

Merged
merged 1 commit into from
Jul 18, 2023
Merged

azurerm_synapse_firewall_rule: fix rule name regex #22571

merged 1 commit into from
Jul 18, 2023

Conversation

Frankkkkk
Copy link

@Frankkkkk Frankkkkk commented Jul 17, 2023 •
edited
Loading

Hi,

The rule name regex is actually more lenient. To quote azure:

The firewall rule name cannot be empty, it cannot contain a
slash (/) or a backslash (\), can't end with '.', and can't
contain '<,>,*,%,&,:,\,/,?'. Additionally, the firewall rule
name cannot exceed 128 characters.

As can be seen on the validation image:
image

Thanks and cheers !

@Frankkkkk Frankkkkk force-pushed the fvd/synapse-firewall-rule branch from 3f7bc4e to cced0cf Compare July 17, 2023 17:02
@Frankkkkk
azurerm_synapse_firewall_rule: fix rule name regex
4eadcca 
The rule name regex is actually more lenient. To quote azure:
```
The firewall rule name cannot be empty, it cannot contain a
slash (/) or a backslash (\), can't end with '.', and can't
contain '<,>,*,%,&,:,\,/,?'. Additionally, the firewall rule
name cannot exceed 128 characters.
```

As can be seen on the validation image:
![image](https://github.com/hashicorp/terraform-provider-azurerm/assets/17879459/eefd1a6e-5dd0-407a-89e0-bbd97b8459d6)

This fixes that

Signed-off-by: Frank Villaro-Dixon <frank.villarodixon@merkle.com>
@Frankkkkk Frankkkkk force-pushed the fvd/synapse-firewall-rule branch from cced0cf to 4eadcca Compare July 17, 2023 17:11
katbyte
katbyte approved these changes Jul 18, 2023
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Frankkkkk - LGTM ♻️

@manicminer manicminer added this to the v3.66.0 milestone Jul 18, 2023
@manicminer manicminer merged commit cf796fe into hashicorp:main Jul 18, 2023
manicminer added a commit that referenced this pull request Jul 18, 2023
@manicminer
Changelog for #22571
cf16dcd
@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@katbyte katbyte katbyte approved these changes

Assignees
No one assigned
Labels
service/synapse size/XS
Projects
None yet
Milestone
v3.66.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Frankkkkk @katbyte @manicminer