Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data azurerm_images - support and fix issue with disk_encryption_set_id #22690

Merged
merged 1 commit into from
Jul 28, 2023

Conversation

myc2h6o
Copy link
Contributor

@myc2h6o myc2h6o commented Jul 26, 2023

d\azurerm_images uses the flatten function in r\azurerm_image, and when adding new property in #22642, there is a schema mismatch in this data source. Fixing the schema and copying the functions out to avoid potential mistake in the future.

Currently the tests are failing due to the issue.
=== CONT TestAccDataSourceAzureRMImages_basic
------- Stderr: -------
panic: Invalid address to set: []string{"images", "0", "os_disk", "0", "disk_encryption_set_id"}

@myc2h6o
Copy link
Contributor Author

myc2h6o commented Jul 26, 2023

Test result
image

Copy link
Member

@catriona-m catriona-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @myc2h6o LGTM!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants