Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for description in network/nat rules in azurerm_firewall_policy_rule_collection_group #23325

Closed
1 task done
MaciejBrowarski opened this issue Sep 19, 2023 · 2 comments · Fixed by #23354
Closed
1 task done

Comments

@MaciejBrowarski
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment and review the contribution guide to help.

Description

Please add --description argument for nat_rule_collection and network_rule in azurerm_firewall_policy_rule_collection_group.
This argument already exist for application_rule in Terraform module.
In SDK/AZ tools such limitation doesn't exists.

New or Affected Resource(s)/Data Source(s)

azurerm_firewall_policy_rule_collection_group

Potential Terraform Configuration

Same as for application_rule in same module:
description - (Optional) The description which should be used for this rule.

References

Terraform page:
https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs/resources/firewall_policy_rule_collection_group#description
AZ page:
https://learn.microsoft.com/en-us/cli/azure/network/firewall/policy/rule-collection-group/collection?view=azure-cli-latest
there is no limitation for --description option.

@rcskosir
Copy link
Contributor

@MaciejBrowarski Thank you for taking the time to open this feature request!

Copy link

github-actions bot commented May 6, 2024

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants