Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_key_vault: new permissions & key_permissions/secret_permissions now optional #2363

Merged
merged 1 commit into from
Nov 26, 2018

Conversation

katbyte
Copy link
Collaborator

@katbyte katbyte commented Nov 20, 2018

fixes #2351

@katbyte katbyte added this to the 1.20.0 milestone Nov 20, 2018
@ghost ghost added the size/M label Nov 20, 2018
Copy link
Collaborator

@WodansSon WodansSon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@katbyte Thanks for the PR. LGTM!

@WodansSon
Copy link
Collaborator

image

The one test that is failing has always failed, no new issues.

@WodansSon WodansSon merged commit a45dca5 into master Nov 26, 2018
@WodansSon WodansSon deleted the b-keyvault-perms branch November 26, 2018 20:05
@ghost
Copy link

ghost commented Mar 5, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Certificate permissions Backup and Restore not allowed by Terraform
2 participants