Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix: fix a bug parsing the table endpoint into a data plane account ID in data.azurerm_storage_table_entity #25307

Merged
merged 3 commits into from
Mar 19, 2024
Merged

bugfix: fix a bug parsing the table endpoint into a data plane account ID in data.azurerm_storage_table_entity #25307

merged 3 commits into from
Mar 19, 2024

Conversation

manicminer
Copy link
Contributor

@manicminer manicminer commented Mar 18, 2024 •
edited
Loading

Also, improve plan-time validation for storage_share_id and storage_table_id properties per this earlier hack.

Closes: #25267

@manicminer manicminer requested a review from a team March 18, 2024 22:08
@manicminer manicminer force-pushed the bugfix/storage-table-entity-data-source-lookup-error branch from f3dc2c6 to 7470f9e Compare March 18, 2024 22:08
@github-actions github-actions bot added size/M and removed size/XS labels Mar 18, 2024
@manicminer manicminer mentioned this pull request Mar 18, 2024
Merged
14 tasks
tombuildsstuff
tombuildsstuff approved these changes Mar 19, 2024
View reviewed changes
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

internal/services/storage/storage_table_entity_data_source.go Outdated Show resolved Hide resolved
@tombuildsstuff tombuildsstuff added this to the v3.97.0 milestone Mar 19, 2024
@manicminer @tombuildsstuff
Typo fix
40e15d7 
Co-authored-by: Tom Harvey <tombuildsstuff@users.noreply.github.com>
@manicminer
Copy link
Contributor Author

Test results

Screenshot 2024-03-19 at 17 08 11

@tombuildsstuff tombuildsstuff merged commit b7c13e9 into main Mar 19, 2024
29 checks passed
@tombuildsstuff tombuildsstuff deleted the bugfix/storage-table-entity-data-source-lookup-error branch March 19, 2024 17:25
tombuildsstuff added a commit that referenced this pull request Mar 19, 2024
@tombuildsstuff
updating to include #25307
a4fbebe
@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tombuildsstuff tombuildsstuff tombuildsstuff approved these changes

Assignees
No one assigned
Labels
bug service/storage size/M
Projects
None yet
Milestone
v3.97.0
Development

Successfully merging this pull request may close these issues.

Unable to use the data source azurerm_storage_table_entity
2 participants
@manicminer @tombuildsstuff