Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_web_application_firewall_policy should support requestBodyEnforcement #25420

Closed
1 task done
rlaveycal opened this issue Mar 26, 2024 · 5 comments · Fixed by #27094
Closed
1 task done

azurerm_web_application_firewall_policy should support requestBodyEnforcement #25420

rlaveycal opened this issue Mar 26, 2024 · 5 comments · Fixed by #27094

Comments

@rlaveycal
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment and review the contribution guide to help.

Description

azurerm_web_application_firewall_policy has a property to control whether the body size should be enforced. This is separate from whether the body should be inspected.

i.e. it is possible to enable body inspection but prevent rejection is the body exceeds the maxRequestBodySizeInKb

See here for the CLI docs

New or Affected Resource(s)/Data Source(s)

azurerm_web_application_firewall_policy

Potential Terraform Configuration

resource "azurerm_web_application_firewall_policy" "this" {
  policy_settings {
    mode                             = "Prevention"
    file_upload_limit_in_mb          = 100
    max_request_body_size_in_kb      = 2000
    request_body_inspect_limit_in_kb = 128
    request_body_check               = true
    request_body_enforcement         = false
  }
}

References

No response

@g-macd
Copy link

g-macd commented Apr 5, 2024

It should also allow for setting the fileUploadEnforcement setting to true or false (file_upload_enforcement)

@chtay1
Copy link

chtay1 commented Apr 18, 2024

Ran into this issue today as well. We have a need to have a request body larger than the maximum 2000Kb and so having the request_body_enforcement flag defaulted to on and not being able to set it via terraform is an issue.

@rajece1989

This comment was marked as off-topic.

@tyagivasu

This comment was marked as off-topic.

Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
7 participants