azurerm_cosmosdb_account: Avoid suggestion to change default_identity_type indefinitely on old account

[Apokalypt]

Community Note

• Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
• Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

This PR handle the case of old CosmosDB Accounts that return an empty string for the property defaultIdentity instead of the expected default value "FirstPartyIdentity". For these accounts even if an update is sent with the value "FirstPartyIdentity" the update will not be applied (without error) and the value will remain empty leading to Terraform to request the change indefinitely...

PR Checklist

• I have followed the guidelines in our Contributing Documentation.
• I have checked to ensure there aren't other open Pull Requests for the same update/change.
• I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
• I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
• I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
  For example: “resource_name_here - description of change e.g. adding property new_property_name_here”

Changes to existing Resource / Data Source

• I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).

Testing

I can't run test that create resources, if someone can do it I would appreciate it

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

• azurerm_cosmosdb_account - Avoid suggestion to change default_identity_type indefinitely on old account

This is a (please select all that apply):

• Bug Fix
• New Feature (ie adding a service, resource, or data source)
• Enhancement
• Breaking Change

Related Issue(s)

Fixes #21951

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

[Apokalypt]

@WodansSon Could you please take a look at this small PR and give your opinion?
Of the various solutions I've explored to fix the bug, this seems the best to avoid adding too much complexity to the resource just to manage old account

[WodansSon]

@Apokalypt, sorry for the late response, things have been kind of hectic at the moment. This LGTM, thanks for opening this PR! 🚀

[Apokalypt]

@Apokalypt, sorry for the late response, things have been kind of hectic at the moment. This LGTM, thanks for opening this PR! 🚀

Ahah no worries @WodansSon , thanks for the feedback 🤝 I will let you merge this PR when you want (can't do it) 👍

[WodansSon]

The tests that failed were test issues, or v4.0 related and had nothing to do with this PR. That said LGTM 🚀

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.