New Resource: `azurerm_dev_center_network_connection` #26718

neil-yechenwei · 2024-07-22T09:51:51Z

Community Note

Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

This PR is to support new resource Dev Center Network Connection.

API Spec: https://github.com/Azure/azure-rest-api-specs/blob/09741dc7c9e43a8f9401d782186cac723dc4af71/specification/devcenter/resource-manager/Microsoft.DevCenter/stable/2023-04-01/vdi.json#L707

Overview: https://learn.microsoft.com/en-us/azure/dev-box/how-to-configure-network-connections?tabs=AzureADJoin

PR Checklist

I have followed the guidelines in our Contributing Documentation.
I have checked to ensure there aren't other open Pull Requests for the same update/change.
I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
For example: “resource_name_here - description of change e.g. adding property new_property_name_here”

Changes to existing Resource / Data Source

I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
I have written new tests for my resource or datasource changes & updated any relevent documentation.
I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
(For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

--- PASS: TestAccDevCenterNetworkConnection_basic (788.66s)
--- PASS: TestAccDevCenterNetworkConnection_requiresImport (721.97s)
--- PASS: TestAccDevCenterNetworkConnection_complete (1301.52s)
--- PASS: TestAccDevCenterNetworkConnection_update (1595.60s)

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

New Resource: azurerm_dev_center_network_connection

This is a (please select all that apply):

Bug Fix
New Feature (ie adding a service, resource, or data source)
Enhancement
Breaking Change

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

…nection

ms-zhenhua

Hi @neil-yechenwei, Thanks for this PR - I've taken a look through and left some comments inline. If we can fix those up, this should be good to go 👍

internal/services/devcenter/dev_center_network_connection_resource_test.go

neil-yechenwei · 2024-07-26T02:56:21Z

@ms-zhenhua , Thanks for the comments. I updated PR. Please take another look. Thanks.

ms-zhenhua

@neil-yechenwei, thank you for your updates. LGTM~

stephybun

Thanks @neil-yechenwei. Overall this is looking good, once you've fixed up the few minor comments then this will be good to go!

stephybun · 2024-07-31T06:00:34Z

internal/services/devcenter/dev_center_network_connection_resource.go

+					if v := props.SubnetId; v != nil {
+						state.SubnetId = pointer.From(v)
+					}
+
+					if v := props.DomainName; v != nil {
+						state.DomainName = pointer.From(v)
+					}
+
+					if v := props.DomainUsername; v != nil {
+						state.DomainUsername = pointer.From(v)
+					}
+
+					if v := props.OrganizationUnit; v != nil {
+						state.OrganizationUnit = pointer.From(v)
+					}


pointer.From can handle the nil check for us so these can be simplified

Suggested change

if v := props.SubnetId; v != nil {

state.SubnetId = pointer.From(v)

}

if v := props.DomainName; v != nil {

state.DomainName = pointer.From(v)

}

if v := props.DomainUsername; v != nil {

state.DomainUsername = pointer.From(v)

}

if v := props.OrganizationUnit; v != nil {

state.OrganizationUnit = pointer.From(v)

}

state.SubnetId = pointer.From(props.SubnetId)

state.DomainName = pointer.From(props.DomainName)

state.DomainUsername = pointer.From(props.DomainUsername)

state.OrganizationUnit = pointer.From(props.OrganizationUnit)

stephybun · 2024-07-31T06:02:31Z

internal/services/devcenter/dev_center_network_connection_resource_test.go

+  lifecycle {
+    ignore_changes = [subnet]
+  }


This change has been reverted so we should remove this

Suggested change

lifecycle {

ignore_changes = [subnet]

}

stephybun · 2024-07-31T06:02:53Z

website/docs/r/dev_center_network_connection.html.markdown

+  lifecycle {
+    ignore_changes = [subnet]
+  }


Suggested change

lifecycle {

ignore_changes = [subnet]

}

…nection

neil-yechenwei · 2024-08-01T04:42:13Z

@stephybun , thanks for the comments. I updated PR. Below is the latest test result I just now triggered.

stephybun

Thanks @neil-yechenwei LGTM 💯

github-actions · 2024-09-03T02:11:53Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

New Resource: azurerm_dev_center_network_connection

475906e

neil-yechenwei marked this pull request as draft July 22, 2024 09:51

github-actions bot added documentation service/dev-center size/XL labels Jul 22, 2024

neil-yechenwei added 2 commits July 22, 2024 19:26

add property validation

e68b08f

add validation

a130051

github-actions bot added the waiting-response label Jul 23, 2024

Merge remote-tracking branch 'upstream/main' into devcenternetworkcon…

6738f8e

…nection

github-actions bot added waiting-response and removed waiting-response labels Jul 23, 2024

Merge remote-tracking branch 'upstream/main' into devcenternetworkcon…

7cf9089

…nection

github-actions bot added waiting-response and removed waiting-response labels Jul 23, 2024

Merge remote-tracking branch 'upstream/main' into devcenternetworkcon…

4ff8a0b

…nection

github-actions bot added waiting-response and removed waiting-response labels Jul 24, 2024

Merge remote-tracking branch 'upstream/main' into devcenternetworkcon…

c497aff

…nection

github-actions bot added waiting-response and removed waiting-response labels Jul 24, 2024

update validation for domain_name

c8a2576

github-actions bot removed the waiting-response label Jul 24, 2024

ms-zhenhua suggested changes Jul 25, 2024

View reviewed changes

internal/services/devcenter/dev_center_network_connection_resource_test.go Show resolved Hide resolved

github-actions bot added the waiting-response label Jul 25, 2024

update tc

0884b96

neil-yechenwei requested a review from ms-zhenhua July 26, 2024 02:56

github-actions bot removed the waiting-response label Jul 26, 2024

ms-zhenhua approved these changes Jul 30, 2024

View reviewed changes

This comment was marked as duplicate.

Sign in to view

neil-yechenwei marked this pull request as ready for review July 30, 2024 02:10

stephybun requested changes Jul 31, 2024

View reviewed changes

github-actions bot added the waiting-response label Jul 31, 2024

neil-yechenwei added 2 commits August 1, 2024 10:29

remove ignorechanges and update read func

e142500

Merge remote-tracking branch 'upstream/main' into devcenternetworkcon…

5122575

…nection

github-actions bot removed the waiting-response label Aug 1, 2024

neil-yechenwei requested a review from stephybun August 1, 2024 04:42

stephybun added the new-resource label Aug 1, 2024

stephybun approved these changes Aug 1, 2024

View reviewed changes

stephybun merged commit 4b2649c into hashicorp:main Aug 1, 2024
37 checks passed

github-actions bot added this to the v3.114.0 milestone Aug 1, 2024

stephybun added a commit that referenced this pull request Aug 1, 2024

Update for #26883 #26865 #26417 #26718 #26890

db29a54

github-actions bot locked as resolved and limited conversation to collaborators Sep 3, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New Resource: `azurerm_dev_center_network_connection` #26718

New Resource: `azurerm_dev_center_network_connection` #26718

neil-yechenwei commented Jul 22, 2024 •

edited

Loading

ms-zhenhua left a comment

neil-yechenwei commented Jul 26, 2024

ms-zhenhua left a comment

This comment was marked as duplicate.

stephybun left a comment

stephybun Jul 31, 2024

neil-yechenwei Aug 1, 2024

stephybun Jul 31, 2024

neil-yechenwei Aug 1, 2024

stephybun Jul 31, 2024

neil-yechenwei Aug 1, 2024

neil-yechenwei commented Aug 1, 2024

stephybun left a comment

github-actions bot commented Sep 3, 2024

New Resource: azurerm_dev_center_network_connection #26718

New Resource: azurerm_dev_center_network_connection #26718

Conversation

neil-yechenwei commented Jul 22, 2024 • edited Loading

Community Note

Description

PR Checklist

Changes to existing Resource / Data Source

Testing

Change Log

ms-zhenhua left a comment

Choose a reason for hiding this comment

neil-yechenwei commented Jul 26, 2024

ms-zhenhua left a comment

Choose a reason for hiding this comment

This comment was marked as duplicate.

stephybun left a comment

Choose a reason for hiding this comment

stephybun Jul 31, 2024

Choose a reason for hiding this comment

neil-yechenwei Aug 1, 2024

Choose a reason for hiding this comment

stephybun Jul 31, 2024

Choose a reason for hiding this comment

neil-yechenwei Aug 1, 2024

Choose a reason for hiding this comment

stephybun Jul 31, 2024

Choose a reason for hiding this comment

neil-yechenwei Aug 1, 2024

Choose a reason for hiding this comment

neil-yechenwei commented Aug 1, 2024

stephybun left a comment

Choose a reason for hiding this comment

github-actions bot commented Sep 3, 2024

New Resource: `azurerm_dev_center_network_connection` #26718

New Resource: `azurerm_dev_center_network_connection` #26718

neil-yechenwei commented Jul 22, 2024 •

edited

Loading