azurerm_monitor_data_collection_rule - update performance_counter.x.sampling_frequency_in_seconds range 1 to 1800

[KiPIDesTAN]

Community Note

• Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
• Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

Data collection rules with a performance_counter data source have a sampling_frequency_in_seconds range of 1 through 1800. The current range validation function on the azurerm_monitor_data_collection_rule resource is from 1 through 300. This prevents anyone wanting to query performance counters at an interval between 5 and 30 minutes from doing so with the current azurerm_monitor_data_collection_rule resource.

The valid range is defined within the Azure control plane and can be viewed within the Azure Portal by creating a performance counter data source. See the screenshot below.

Within this PR are additional changes to the testAccMonitorDataCollectionRule_complete acceptance test within "func (r MonitorDataCollectionRuleResource) complete(data acceptance.TestData)". I am calling this out because the modifications are unrelated to the code change, but required within the test because the scenarios they are testing are not valid data collection rule configurations.

The changes are below.

Removed:

  data_flow {
    streams       = ["Custom-MyTableRawData"]
    destinations  = ["test-destination-log"]
    output_stream = "Microsoft-Syslog"
    transform_kql = "source | project TimeGenerated = Time, Computer, Message = AdditionalContext"
  }

Reason: Data collection rules do not allow custom data streams (Custom-MyTableRawData) to write to Microsoft-delivered tables (output_stream = "Microsoft-Syslog"). This ability is blocked at the control plane level and an error occurs indicating the aforementioned restriction when run in Azure Public Cloud.

Removed:

platform_telemetry {
      streams = ["Microsoft.Cache/redis:Metrics-Group-All"]
      name    = "test-datasource-telemetry"
    }

Reason: Platform telemetry is a not a generally available data source and requires a user to reach out to Microsoft and opt in to the non-public functionality.

PR Checklist

• I have followed the guidelines in our Contributing Documentation.
• I have checked to ensure there aren't other open Pull Requests for the same update/change.
• I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
• I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
• I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
  For example: “resource_name_here - description of change e.g. adding property new_property_name_here”

Changes to existing Resource / Data Source

• I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
• I have written new tests for my resource or datasource changes & updated any relevent documentation.
• I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
• (For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

• My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

• azurerm_monitor_data_collection_rule - Fixes sampling_frequency_in_seconds range to be 1 to 1800 for performance counters [azurerm_monitor_data_collection_rule - sampling_frequency_in_seconds incorrect range constraint #26897]

This is a (please select all that apply):

• Bug Fix
• New Feature (ie adding a service, resource, or data source)
• Enhancement
• Breaking Change

Related Issue(s)

Fixes #26897

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

[mbfrahry]

LGTM!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.