Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azurerm_virtual_network_gateway_connection - Setting sa_datasize to allow 0 #27056

Merged
merged 3 commits into from
Aug 20, 2024
Merged

azurerm_virtual_network_gateway_connection - Setting sa_datasize to allow 0 #27056

merged 3 commits into from
Aug 20, 2024

Conversation

ErgoPr0xy
Copy link
Contributor

Same issue as #24880

Fixes #21407

@ErgoPr0xy ErgoPr0xy changed the title azurerm_virtual_network_gateway_connection - Setting sa_datasize to allow 0 azurerm_virtual_network_gateway_connection - Setting sa_datasize to allow 0 Aug 16, 2024
stephybun
stephybun requested changes Aug 20, 2024
View reviewed changes
Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ErgoPr0xy. Could you take a look at the suggestions left in-line about the test configs? Once those are resolved this should be good to go!

internal/services/network/virtual_network_gateway_connection_resource_test.go Outdated Show resolved Hide resolved
internal/services/network/virtual_network_gateway_connection_resource_test.go Outdated Show resolved Hide resolved
@ErgoPr0xy @stephybun
Update internal/services/network/virtual_network_gateway_connection_r…
4e0e051 
…esource_test.go

Co-authored-by: stephybun <steph@hashicorp.com>
@ErgoPr0xy @stephybun
Update internal/services/network/virtual_network_gateway_connection_r…
9d6dd6a 
…esource_test.go

Co-authored-by: stephybun <steph@hashicorp.com>
@ErgoPr0xy
Copy link
Contributor Author

Thanks @ErgoPr0xy. Could you take a look at the suggestions left in-line about the test configs? Once those are resolved this should be good to go!

Thanks @stephybun, makes sense! Better variation amongst the validation tests so we don't just test 0. I've committed your suggestions 🙏

@stephybun stephybun added the bug label Aug 20, 2024
stephybun
stephybun approved these changes Aug 20, 2024
View reviewed changes
Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ErgoPr0xy LGTM 🍨

@stephybun stephybun merged commit 09406af into hashicorp:main Aug 20, 2024
30 checks passed
@github-actions github-actions bot added this to the v3.117.0 milestone Aug 20, 2024
@stephybun stephybun modified the milestones: v3.117.0, v4.0.0 Aug 21, 2024
@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stephybun stephybun stephybun approved these changes

Assignees
No one assigned
Labels
bug service/network size/XS
Projects
None yet
Milestone
v4.0.0
Development

Successfully merging this pull request may close these issues.

VPN gateway connection SA lifetime in kilobytes value 0
2 participants
@ErgoPr0xy @stephybun