Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_kubernetes_cluster - set host_encryption_enabled and remove 4.0 flags #27218

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

catriona-m
Copy link
Member

Community Note

  • Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
  • Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

This PR fixes a bug where host_encryption_enabled is not being set correctly and removes 4.0 flags around these since 4.0 has now been released

PR Checklist

  • I have followed the guidelines in our Contributing Documentation.
  • I have checked to ensure there aren't other open Pull Requests for the same update/change.
  • I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
  • I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
  • I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
    For example: “resource_name_here - description of change e.g. adding property new_property_name_here

Testing

  • My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

Testing in TC

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

  • azurerm_kubernetes_cluster - host_encryption_enabled and node_public_ip_enabled are now set correctly

This is a (please select all that apply):

  • Bug Fix
  • New Feature (ie adding a service, resource, or data source)
  • Enhancement
  • Breaking Change

Related Issue(s)

Fixes #27201

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

@catriona-m catriona-m marked this pull request as draft August 27, 2024 14:23
@catriona-m catriona-m marked this pull request as ready for review August 27, 2024 16:32
@catriona-m catriona-m requested a review from a team August 27, 2024 16:32
@slushysnowman
Copy link
Contributor

Would be great if this could be merged, this is a disruptive bug...

Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @catriona-m LGTM 👍

@catriona-m catriona-m merged commit ff903f1 into main Sep 5, 2024
32 checks passed
@catriona-m catriona-m deleted the cm/fourpointohkubclusterbug branch September 5, 2024 10:11
@github-actions github-actions bot added this to the v4.1.0 milestone Sep 5, 2024
catriona-m added a commit that referenced this pull request Sep 5, 2024
Copy link

github-actions bot commented Oct 6, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants