Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Microsoft.DevOpsInfrastructure as allowed services for subnet delegation #27259

Merged
merged 4 commits into from
Sep 6, 2024

Conversation

schdief
Copy link
Contributor

@schdief schdief commented Sep 2, 2024

https://learn.microsoft.com/en-us/azure/devops/managed-devops-pools/prerequisites?view=azure-devops&tabs=azure-portal#azure-portal-1

Community Note

  • Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
  • Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

Microsoft released a new service called Managed DevOps agents. To use it, one needs to delegate a subnet to the service Microsoft.DevOpsInfrastructure according to the docs: https://learn.microsoft.com/en-us/azure/devops/managed-devops-pools/prerequisites?view=azure-devops&tabs=azure-portal#azure-portal-1

PR Checklist

  • I have followed the guidelines in our Contributing Documentation.
  • I have checked to ensure there aren't other open Pull Requests for the same update/change.
  • I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
  • I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
  • I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
    For example: “resource_name_here - description of change e.g. adding property new_property_name_here

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

  • azurerm_subnet - support Microsoft.DevOpsInfrastructure as delegation service

This is a (please select all that apply):

  • Bug Fix
  • New Feature (ie adding a service, resource, or data source)
  • Enhancement
  • Breaking Change

Related Issue(s)

Fixes #0000

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

schdief and others added 2 commits September 3, 2024 06:26
Co-authored-by: Ajay <40024974+ajaykn@users.noreply.github.com>
@schdief
Copy link
Contributor Author

schdief commented Sep 4, 2024

Resolves: #26412

@haflidif no it doesn't, this PR merely allows to delegate the subnet, but it doesn't provide a new module to deploy the Managed DevOps Pool itself, please remove the reference so the issue isn't closed with the merge

@haflidif
Copy link

haflidif commented Sep 4, 2024

Resolves: #26412

@haflidif no it doesn't, this PR merely allows to delegate the subnet, but it doesn't provide a new module to deploy the Managed DevOps Pool itself, please remove the reference so the issue isn't closed with the merge

My apologizes for misreading the Issue, I was to eager to link these two together, thought the issue was mainly about adding the Delegation on the Subnet.

After reading it better now, I see it's a request for the whole resource, not only the requirements it needs on the Subnet.

It's been removed now, thanks for paying attention to the details.

@schdief
Copy link
Contributor Author

schdief commented Sep 4, 2024

Resolves: #26412

@haflidif no it doesn't, this PR merely allows to delegate the subnet, but it doesn't provide a new module to deploy the Managed DevOps Pool itself, please remove the reference so the issue isn't closed with the merge

My apologizes for misreading the Issue, I was to eager to link these two together, thought the issue was mainly about adding the Delegation on the Subnet.

After reading it better now, I see it's a request for the whole resource, not only the requirements it needs on the Subnet.

It's been removed now, thanks for paying attention to the details.

no worries, thanks for trying to help :)

@wjdavis5
Copy link

wjdavis5 commented Sep 4, 2024

very happy someone beat me to this ;-)
Thanks!

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ☄️

@katbyte katbyte merged commit 3ace440 into hashicorp:main Sep 6, 2024
33 checks passed
@github-actions github-actions bot added this to the v4.1.0 milestone Sep 6, 2024
katbyte added a commit that referenced this pull request Sep 6, 2024
Copy link

github-actions bot commented Oct 6, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants