-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
azurerm_cosmosdb_account
- add state migration for ip_range_filter
underlying type change
#27276
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jackofallops other than the unnecessary attributes in the schema for the state migration LGTM 🐼
This caused #27308 edge case 4.0.1 -> 4.1.0 migration to break |
https://github.com/hashicorp/terraform-provider-azurerm/pull/27276/files#diff-8d781d625516e2d8f83c0d0b3458a4eb1a737483c00ee33c2d7c7e32effd8335R560 a type check for string would fix migration from 4.0.1 -> 4.1.0 issue #27308 @jackofallops |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Community Note
Description
Migrates the type of
ip_range_filter
fromstring
toset
.Removes pre-4.0 code paths
PR Checklist
For example: “
resource_name_here
- description of change e.g. adding propertynew_property_name_here
”Changes to existing Resource / Data Source
Testing
Change Log
Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.
azurerm_resource
- support for thething1
property [GH-00000]This is a (please select all that apply):
Related Issue(s)
Closes #27192
Closes #27242
Note
If this PR changes meaningfully during the course of review please update the title and description as required.