Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dependencies: update to latest go-azure-sdk v0.20240923.1151247 and implement discriminated child models #27491

Merged
merged 6 commits into from
Sep 25, 2024

Conversation

manicminer
Copy link
Contributor

  • Update all instances where response structs previously referenced *interface{} for discriminated models, but now return a (non-pointer) named interface.

  • Where payloads for discriminated models previously used maps as a crutch, attempt to use the child model type wherever possible.

  • For aurerm_role_management_policy, the child models are currently not resolved correctly in Pandora and as such don't yet exist in the SDK. As a workaround, define a type for this model in the resource package so that it can be typed, and crucially so that it can satisfy the new parent model interface.

* Update all instances where response structs previously referenced `*interface{}`
  for discriminated models, but now return a (non-pointer) named interface.

* Where payloads for discriminated models previously used maps as a crutch, attempt
  to use the child model type wherever possible.

* For `aurerm_role_management_policy`, the child models are currently not resolved
  correctly in Pandora and as such don't yet exist in the SDK. As a workaround,
  define a type for this model in the resource package so that it can be typed,
  and crucially so that it can satisfy the new parent model interface.
@manicminer
Copy link
Contributor Author

manicminer commented Sep 24, 2024

Authorization

Screenshot 2024-09-24 at 23 45 11

Data Share

Screenshot 2024-09-24 at 22 47 06

FrontDoor

Failure unrelated.

Screenshot 2024-09-24 at 22 46 03

Kusto

Failures are due to destroy-time errors.

Screenshot 2024-09-25 at 16 31 13

Machine Learning

Screenshot 2024-09-24 at 23 44 29

Network

This is a sequential/combined test, failure is unrelated.

Screenshot 2024-09-25 at 11 23 51

Screenshot 2024-09-25 at 11 24 14

Recovery Services

Failures exist in main (flaky tests).

Screenshot 2024-09-25 at 16 33 04

Resources

Screenshot 2024-09-24 at 23 57 33

Security Center

Screenshot 2024-09-25 at 11 45 22

Sentinel

Failures unrelated, see also hashicorp/pandora#4446

Screenshot 2024-09-25 at 11 36 53

ServiceConnector

Screenshot 2024-09-25 at 12 17 29

Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@manicminer manicminer merged commit 9f54222 into main Sep 25, 2024
29 checks passed
@manicminer manicminer deleted the dependencies/go-azure-sdk-v0.20240923.1151247 branch September 25, 2024 15:36
@github-actions github-actions bot added this to the v4.4.0 milestone Sep 25, 2024
manicminer added a commit that referenced this pull request Sep 25, 2024
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants