-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dependencies: update to latest go-azure-sdk v0.20240923.1151247 and implement discriminated child models #27491
dependencies: update to latest go-azure-sdk v0.20240923.1151247 and implement discriminated child models #27491
Conversation
…orp/go-azure-sdk`
* Update all instances where response structs previously referenced `*interface{}` for discriminated models, but now return a (non-pointer) named interface. * Where payloads for discriminated models previously used maps as a crutch, attempt to use the child model type wherever possible. * For `aurerm_role_management_policy`, the child models are currently not resolved correctly in Pandora and as such don't yet exist in the SDK. As a workaround, define a type for this model in the resource package so that it can be typed, and crucially so that it can satisfy the new parent model interface.
AuthorizationData ShareFrontDoorFailure unrelated. KustoFailures are due to destroy-time errors. Machine LearningNetworkThis is a sequential/combined test, failure is unrelated. Recovery ServicesFailures exist in ResourcesSecurity CenterSentinelFailures unrelated, see also hashicorp/pandora#4446 ServiceConnector |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…computed values are unknown/zero at plan time
…est as it is only changing two properties and one of them is ForceNew
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Update all instances where response structs previously referenced
*interface{}
for discriminated models, but now return a (non-pointer) named interface.Where payloads for discriminated models previously used maps as a crutch, attempt to use the child model type wherever possible.
For
aurerm_role_management_policy
, the child models are currently not resolved correctly in Pandora and as such don't yet exist in the SDK. As a workaround, define a type for this model in the resource package so that it can be typed, and crucially so that it can satisfy the new parent model interface.