Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Data Source: azurerm_key_vault_managed_hardware_security_module_key #27827

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

wuxu92
Copy link
Contributor

@wuxu92 wuxu92 commented Oct 31, 2024

Description

Add New Data Source for Managed Hardware Security Module Key. Also removed some legacy tests.

PR Checklist

  • I have followed the guidelines in our Contributing Documentation.
  • I have checked to ensure there aren't other open Pull Requests for the same update/change.
  • I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
  • I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
  • I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
    For example: “resource_name_here - description of change e.g. adding property new_property_name_here

Testing

  • My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)
=== RUN   TestAccKeyVaultManagedHardwareSecurityModule
=== RUN   TestAccKeyVaultManagedHardwareSecurityModule/keys
=== RUN   TestAccKeyVaultManagedHardwareSecurityModule/keys/data_source
=== PAUSE TestAccKeyVaultManagedHardwareSecurityModule/keys/data_source
=== CONT  TestAccKeyVaultManagedHardwareSecurityModule/keys/data_source
--- PASS: TestAccKeyVaultManagedHardwareSecurityModule (2049.21s)
    --- PASS: TestAccKeyVaultManagedHardwareSecurityModule/keys (0.00s)
        --- PASS: TestAccKeyVaultManagedHardwareSecurityModule/keys/data_source (2049.21s)

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

  • New Data Source: azurerm_key_vault_managed_hardware_security_module_key

This is a (please select all that apply):

  • Bug Fix
  • New Feature (ie adding a service, resource, or data source)
  • Enhancement
  • Breaking Change

Related Issue(s)

Fixes #27747

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎬

@katbyte katbyte merged commit 504be4d into hashicorp:main Nov 15, 2024
33 checks passed
@github-actions github-actions bot added this to the v4.10.0 milestone Nov 15, 2024
katbyte added a commit that referenced this pull request Nov 15, 2024
@wuxu92 wuxu92 deleted the hsm/key-data-source branch November 15, 2024 02:25
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for getting keys from a Managed HSM Key Vault
3 participants