Feature application gateway customerrors

[mcharriere]

Add custom errors to the Application gateway resource. #2364

Adds global level configuration and listener level configuration using the same block structure.

(fixes #2364)

[tombuildsstuff]

hey @mcharriere

Thanks for this PR :)

I've taken a look through and this mostly LGTM - if we can fix up the minor comments then we should be able to run the tests and get this merged 👍

Thanks!

[tombuildsstuff]

hey @mcharriere

Thanks for pushing those changes - this now LGTM, I'll kick off the test suite shortly 👍

Thanks!

[katbyte]

Hi @mcharriere,

There were a few errors in the test config i have fixed, however the test is now failing with:

UPDATE: azurerm_application_gateway.test
          http_listener.0.custom_error_configuration.0.custom_error_page_url: "http://azure.com/error.html" => "http://azure.com/error403_listener.html"
          http_listener.0.custom_error_configuration.1.custom_error_page_url: "http://azure.com/error.html" => "http://azure.com/error502_listener.html"

[mcharriere]

Hi @mcharriere,

There were a few errors in the test config i have fixed, however the test is now failing with:

UPDATE: azurerm_application_gateway.test
          http_listener.0.custom_error_configuration.0.custom_error_page_url: "http://azure.com/error.html" => "http://azure.com/error403_listener.html"
          http_listener.0.custom_error_configuration.1.custom_error_page_url: "http://azure.com/error.html" => "http://azure.com/error502_listener.html"

I think that the problem is that I was calling the expand function inside the listener. That would set the configuration for the global level inside the listener.
I was able to fix that by changing the argument that the function receives, so the same function expands the block avoiding code dup. Is that ok?

[katbyte]

Thanks @mcharriere, LGTM now 🙂

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!