Added keys to output for cog service account

[JimPaine]

When creating a cognitive service account the keys were not returned so you were unable to configure downstream services.

Related Issue #2567

Key things to note:

• I couldn't see tests around the other outputs so haven't modified them, i.e. "endpoint" happy to add if it is felt to be required.
• I also noticed that some resource change the terminology around key names for eg. key1 -> primary key but I have left to match the RESTful api and GO SDK.

(fixes #2567)

[katbyte]

Hi @JimPaine,

Thank you for the enhancement! It is a bit weird for it to be key1 and key2, what does the portal say? I think we should align most closely with that over the API.

We should add a check to the tests to ensure the properties are set:

resource.TestCheckResourceAttrSet(resourceName, "key1"),

Also could we add these new properties to the documentation?

[JimPaine]

Hi @katbyte It is also in the portal as key1 and key2 so while it may seem a little odd it is probably best to keep it aligned? I will work on the requested changes so thanks for the feedback.

[JimPaine]

Suggested changes made and I have also commented on the points around what to do when we fail to get the keys, agreed with the thoughts and have wrapped up the err rather than removing the resource.

[JimPaine]

Tests and documents updated

[tombuildsstuff]

hey @JimPaine

Thanks for this PR :)

I've taken a look through and whilst this LGTM I've got some questions around the naming of the fields - I believe it'd be better to match the naming of the other resources; what do you think?

Thanks!

[JimPaine]

@tombuildsstuff Updated keys to match terraform naming rather than the API, ensuring a consistency between documentation and resources.

[tombuildsstuff]

hey @JimPaine

Thanks for pushing those changes - there's a couple of minor docs phasing changes which could make more sense upon reflection (which I'm going to push a commit for) but this otherwise LGTM 👍

Thanks!

[tombuildsstuff]

Tests pass:

dismissing since changes have been pushed

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!