AKS with VMSS

[epa095]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

az can create aks clusters with virtual scale sets enabled by --enable-vmss, and we would like to be able to do the same in terraform. VMSS is a requirement for node autoscaling, which is cool.

New or Affected Resource(s)

• azurerm_kubernetes_cluster

[Lucretius]

It looks like the new version of the SDK contains the necessary autoscaling configuration properties so this can be done with a bump to the containerservice API version being used.

[tombuildsstuff]

@Lucretius the new version of the SDK being the SDK version or the API Version?

[Lucretius]

Sorry, the new version of the API within the existing SDK. See here

[tombuildsstuff]

@Lucretius looks like this would require bumping the Azure SDK too, we're currently using v25.1.0 where that API version isn't available: https://github.com/Azure/azure-sdk-for-go/tree/v25.1.0/services/containerservice/mgmt

[djsly]

I was looking at the same thing.

https://github.com/Azure/azure-sdk-for-go/tree/v26.5.0/services/containerservice/mgmt/2019-02-01/containerservice

comes with >= v26.5.0

@tombuildsstuff do you need to track the bump of the sdk in a separate issues / PR

[tombuildsstuff]

@djsly sorry I meant to open a PR for the SDK upgrade last week (but it dropped off my radar) - let me do that now

[tombuildsstuff]

@djsly PR to update the SDK: #3126

[landro]

Please also remember adding availability zone support while enabling vmss.

Availability zones are currently supported in the go SDK

	// AvailabilityZones - (PREVIEW) Availability zones for nodes. Must use VirtualMachineScaleSets AgentPoolType.
AvailabilityZones *[]string `json:"availabilityZones,omitempty"`

References

https://github.com/Azure/azure-sdk-for-go/blob/master/services/containerservice/mgmt/2019-04-30/containerservice/models.go

https://github.com/Azure/azure-cli-extensions/tree/master/src/aks-preview#enable-vmss-for-new-cluster-with-availability-zone-feature

[epa095]

I guess this can be closed now that #3422 is merged @dominik-lekse?

[dominik-lekse]

@epa095 @tombuildsstuff Yes, this feature is in the latest 1.28.0 release and the issue can be closed.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!