Feature Request: azurerm_container_group : add liveness and readiness probes

[neilpeterson]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Add readiness and liveness probes to the azurerm_container_group resource.

I have completed a quick POC and would be happy to take dibs on the engineering work once the specification has been agreed on. Here is the PR - #3118.

New or Affected Resource(s)

• azurerm_container_group

Potential Terraform Configuration

resource "azurerm_container_group" "probe-test" {
  name                = "probe-test"
  location            = "${azurerm_resource_group.probe-test.location}"
  resource_group_name = "${azurerm_resource_group.probe-test.name}"
  os_type             = "linux"
  ip_address_type     = "public"

  container {
    name   = "probe-test"
    image  = "nginx"
    cpu    = "1"
    memory = "1.5"

    ports = {
      port = 80
      protocol = "TCP"
    }

    commands = ["/bin/sh","-c","sleep 30","touch /tmp/healthy; sleep 30; rm -rf /tmp/healthy; sleep 600"]

    readiness_probe {
      exec = ["cat","/tmp/healthy"]
      inital_delay_seconds = 10
      period_seconds = 5
      failure_threashold = 3
      sucess_threashold = 1
      timeout_seconds = 120
    }

    liveness_probe {
      exec = ["cat","/tmp/healthy"]
      inital_delay_seconds = 10
      period_seconds = 60
      failure_threashold = 3
      sucess_threashold = 1
      timeout_seconds = 120
    }
  }
}

References

Liveness Probes - https://docs.microsoft.com/en-us/azure/container-instances/container-instances-liveness-probe

Kubernetes definition for each property - https://kubernetes.io/docs/tasks/configure-pod-container/configure-liveness-readiness-probes/#configure-probes

SDK Reference - https://github.com/Azure/azure-sdk-for-go/blob/master/services/containerinstance/mgmt/2018-10-01/containerinstance/models.go#L844

[neilpeterson]

Closing per PR - #3118

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!