Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No obious way to control "Basic Metrics" in "Diagnostics settings" in Azure VM #317

Closed
hashibot opened this issue Sep 8, 2017 · 4 comments

Comments

@hashibot
Copy link

hashibot commented Sep 8, 2017

This issue was originally opened by @wawrzek as hashicorp/terraform#16050. It was migrated here as a result of the provider split. The original body of the issue is below.


There are a profile block to control Boot Diagnostic for Azure VM, but there is nothing to control "Basic Metrics". This option is in the same space in Azure portal, so it make sense keep them togher in Terraform.
Therefore, "boot_diagnostic" should be rename "diagnostic_settings", "boot_diagnostic" should replace "enabled" and there should be new variable "basic_metrics".

The profile should looks like:

diagnostic_settings {
  boot_diagnostics = "[true|false]" 
  basic_metrics = "[true|false]"
  storage_uri = "blog_uri(string)"
}

Terraform Version

Terraform v0.10.4
terraform-provider-azurerm_v0.1.6_x4

Terraform Configuration Files

No special configuration

@tombuildsstuff
Copy link
Contributor

Hey @wawrzek

Thanks for opening this issue :)

This functionality has previously been requested in #199 - and Basic Metrics can be activated as a VM Extension for either Windows or Linux VM's. Unfortunately this flag isn't exposed in the API at the current time and can only be added through the VM Extension, however I've previously requested this is added to the Azure API's in this Rest API Specs Repository issue.

Given the amount of API Logic that would be involved with reimplementing this within Terraform (such as determining the underlying OS for each VM/Marketplace image; and the associated defaults for that OS), plus the potential for drift between the Portal's defaults and our defaults - we've currently opted to recommend using VM Extensions for this functionality. That said - as soon as it's available in the API we'll investigate this further, as it's not an optimal user experience.

In the interim, would it be possible to take a look and see if the VM Extension mentioned above solves your issue here? :)

Thanks!

@wawrzek
Copy link

wawrzek commented Sep 18, 2017

@tombuildsstuff - I suggest to make clear in documentation, that these 2 things are quite different beasts even if they are cramped together in portal.
VM extension is good enough for me. The only problem is that I cannot make it work. I've been adding comments to https://gist.github.com/tombuildsstuff/1e214b15fe12664d175622c8a02fdf00

@tombuildsstuff
Copy link
Contributor

👋 hi all

Since the Azure Compute team don't plan on adding this functionality to the Azure API unfortunately we're unable to proceed with this issue. If you'd like to see support for this I'd suggest opening an issue with Microsoft - however #1291 may provide an alternate solution.

As there's no immediate path forward for this issue I'm going to close this issue for the moment.

Thanks!

@tombuildsstuff tombuildsstuff removed this from the Being Sorted milestone Oct 25, 2018
@ghost
Copy link

ghost commented Mar 6, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants