Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contents of custom data visible in plan as base64 encoded string #6185

Closed
kazimierzbudzyk opened this issue Mar 19, 2020 · 3 comments · Fixed by #6225
Closed

Contents of custom data visible in plan as base64 encoded string #6185

kazimierzbudzyk opened this issue Mar 19, 2020 · 3 comments · Fixed by #6225
Labels
Milestone

Comments

@kazimierzbudzyk
Copy link
Contributor

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Terraform (and AzureRM Provider) Version

terraform v0.12.20
provider.azurerm v2.0.0

Affected Resource(s)

  • azurerm_linux_virtual_machine

Terraform Configuration Files

resource "azurerm_linux_virtual_machine" "example" {
  name                = "example-machine"
  resource_group_name = azurerm_resource_group.example.name
  location            = azurerm_resource_group.example.location
  size                = "Standard_F2"
  admin_username      = "adminuser"
  
  custom_data = base64encode(jsonencode({
    "key" = "value"
  }))

  network_interface_ids = [
    azurerm_network_interface.example.id,
  ]

  admin_ssh_key {
    username   = "adminuser"
    public_key = file("~/.ssh/id_rsa.pub")
  }

  os_disk {
    caching              = "ReadWrite"
    storage_account_type = "Standard_LRS"
  }

  source_image_reference {
    publisher = "Canonical"
    offer     = "UbuntuServer"
    sku       = "16.04-LTS"
    version   = "latest"
  }
}

Expected Behavior

Custom data not being printed in terraform plan output. Which was the behaviour in ARM1.X provider.

Actual Behavior

ARM2.0 makes contents of custom data print out in plan as base64 encoded string.
Most likely can be fixed by adding Sensitive: true to the schema of custom data field: https://github.com/terraform-providers/terraform-provider-azurerm/blob/master/azurerm/internal/tf/base64/schema.go

Steps to Reproduce

  1. terraform plan
@tombuildsstuff
Copy link
Contributor

Fixed via #6225

@tombuildsstuff tombuildsstuff added this to the v2.3.0 milestone Mar 25, 2020
@ghost
Copy link

ghost commented Mar 27, 2020

This has been released in version 2.3.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.3.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Apr 24, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
2 participants