Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for access policies and EventSources for Time Series Insights #7053

Closed
alex-3sr opened this issue May 22, 2020 · 4 comments
Closed

Comments

@alex-3sr
Copy link

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Hi All,

First, thank to add recently support for TSI environnements, with azurerm_time_series_insights_standard_environment ;)
For complete a full TSI deployment, we need at least 2 others parts of ressources ->

  • Events Sources : "Microsoft.TimeSeriesInsights/environments/eventsources"
  • Access Policies : "Microsoft.TimeSeriesInsights/environments/accesspolicies"

It could be nice to have theses 2 new ressources with the new one, for complete now a full TSI deployment without requiring to use ARM template.

Thanks ;)

New or Affected Resource(s)

The 2 new TF resources could be like this ->

  • azurerm_time_series_insights_eventsources
  • azurerm_time_series_insights_access_policy

Potential Terraform Configuration

  • azurerm_time_series_insights_eventsources
resource "azurerm_time_series_insights_eventsources" "example" {
  name = "example"
  location = resource.rg.location
  tsi_environnement = resource.azurerm_time_series_insights_standard_environment.id
  kind = "Microsoft.EventHub"
  properties {
    servicebusnamespaceId = "/subscriptions/xxxx/xxxx"
	eventhubname = "eventhubexample"
	keyname = "mykey"
	consumergroupname = "$Default"
	sharedAccessKey = "xxxxxxxxxxxxxxxxxxx"
  }
}
  • azurerm_time_series_insights_access_policy
resource "azurerm_time_series_insights_access_policy" "example" {
  name = "example"
  tsi_environnement = resource.azurerm_time_series_insights_standard_environment.id
  object_id = "11111111-1111-1111-1111-111111111111"
  roles = ["Reader","Contributor"]
}

References

TSI Access Policies : https://docs.microsoft.com/en-us/azure/templates/microsoft.timeseriesinsights/2017-11-15/environments/accesspolicies
TSI Event sources : https://docs.microsoft.com/en-us/azure/templates/microsoft.timeseriesinsights/2017-11-15/environments/eventsources

@alex-3sr
Copy link
Author

Hi,

I see that now is available https://www.terraform.io/docs/providers/azurerm/r/iot_time_series_insights_access_policy.html ;) thank you. Although, I noticed an error in documentation ->
resource_group_name - (Required) The name of the resource group in which to create the Azure IoT Time Series Insights Access Policy.

resource_group_name is not required and more, it's not an accepted argument ;) Please, can you remove it from the doc.

Thanks
Regards

@Lachlan-White
Copy link
Contributor

Very keen to see Event Sources as a resource for TSI. The TSI Resource isn't able to do a lot without having this available for configuration, and it's a bit clunky doing half with Terraform and half with ARM at the moment

@favoretti
Copy link
Collaborator

Thanks for opening this issue! Since this issue seems to have been addressed in the latest versions of the provider - I'm going to close it. Please open a new updated bug report if this is still relevant. Thank you.

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants