Add insecure option as requested in GH-6

[natefaerber]

#6

This adds the insecure option. I used insecure instead of ssl_verify because I saw the same option in OpenStack provider so thought it would be more acceptable. https://github.com/terraform-providers/terraform-provider-openstack/blob/master/openstack/config.go#L28

I haven't been able to do a real world test against an insecure endpoint. I might be able to do that tomorrow.

$ make testacc TESTARGS='-run=TestResourceProvider'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test $(go list ./... |grep -v 'vendor') -v -run=TestResourceProvider -timeout 120m
?   	github.com/terraform-providers/terraform-provider-consul	[no test files]
=== RUN   TestResourceProvider
--- PASS: TestResourceProvider (0.00s)
=== RUN   TestResourceProvider_impl
--- PASS: TestResourceProvider_impl (0.00s)
=== RUN   TestResourceProvider_Configure
2017/12/26 21:52:13 [INFO] Initializing Consul client
2017/12/26 21:52:13 [INFO] Consul Client configured with address: 'demo.consul.io:80', scheme: 'https', datacenter: 'nyc3', insecure: 'false'
--- PASS: TestResourceProvider_Configure (0.00s)
=== RUN   TestResourceProvider_ConfigureTLS
2017/12/26 21:52:13 [INFO] Initializing Consul client
2017/12/26 21:52:13 [INFO] Consul Client configured with address: 'demo.consul.io:80', scheme: 'https', datacenter: 'nyc3', insecure: 'false'
--- PASS: TestResourceProvider_ConfigureTLS (0.00s)
=== RUN   TestResourceProvider_ConfigureTLSInsecure
2017/12/26 21:52:13 [INFO] Initializing Consul client
2017/12/26 21:52:13 [INFO] Consul Client configured with address: 'demo.consul.io:80', scheme: 'https', datacenter: 'nyc3', insecure: 'true'
--- PASS: TestResourceProvider_ConfigureTLSInsecure (0.00s)
PASS
ok  	github.com/terraform-providers/terraform-provider-consul/consul	0.020s

[natefaerber]

Note that this would close #4, too.

[apparentlymart]

Hi @natefaerber! Thanks for working on this.

The functionality here looks good to me. The name feels a little off though, since "insecure" sounds to me like "disable TLS" rather than "skip certificate verification".

What do you think about calling it insecure_https instead, to clarify that it's a modifier for the HTTPS behavior rather than disabling HTTPS altogether? Ideally this would also raise an error if scheme is set to anything other than https, to further clarify that this setting adjusts the behavior for HTTPS mode.

[natefaerber]

Error string if insecure_https is set but scheme is not https.

[natefaerber]

tests that we error if insecure_https is used without https

[natefaerber]

Good idea, @apparentlymart. I have made these changes. Please review the strings to see if they make sense.

$ make testacc TESTARGS='-run=TestResourceProvider'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test $(go list ./... |grep -v 'vendor') -v -run=TestResourceProvider -timeout 120m
?   	github.com/terraform-providers/terraform-provider-consul	[no test files]
=== RUN   TestResourceProvider
--- PASS: TestResourceProvider (0.00s)
=== RUN   TestResourceProvider_impl
--- PASS: TestResourceProvider_impl (0.00s)
=== RUN   TestResourceProvider_Configure
2018/01/06 11:03:58 [INFO] Initializing Consul client
2018/01/06 11:03:58 [INFO] Consul Client configured with address: 'demo.consul.io:80', scheme: 'https', datacenter: 'nyc3', insecure_https: 'false'
--- PASS: TestResourceProvider_Configure (0.00s)
=== RUN   TestResourceProvider_ConfigureTLS
2018/01/06 11:03:58 [INFO] Initializing Consul client
2018/01/06 11:03:58 [INFO] Consul Client configured with address: 'demo.consul.io:80', scheme: 'https', datacenter: 'nyc3', insecure_https: 'false'
--- PASS: TestResourceProvider_ConfigureTLS (0.00s)
=== RUN   TestResourceProvider_ConfigureTLSInsecureHttps
2018/01/06 11:03:58 [INFO] Initializing Consul client
2018/01/06 11:03:58 [INFO] Consul Client configured with address: 'demo.consul.io:80', scheme: 'https', datacenter: 'nyc3', insecure_https: 'true'
--- PASS: TestResourceProvider_ConfigureTLSInsecureHttps (0.00s)
=== RUN   TestResourceProvider_ConfigureTLSInsecureHttpsMismatch
2018/01/06 11:03:58 [INFO] Initializing Consul client
--- PASS: TestResourceProvider_ConfigureTLSInsecureHttpsMismatch (0.00s)
PASS
ok  	github.com/terraform-providers/terraform-provider-consul/consul	0.030s

[vancluever]

This looks good and I've tested the connection on a local Consul dev container with TLS enabled on a self-signed cert. Good work! 👍