Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warning for removal of work around for executables in current directory #197

Open
1 task done
bendbennett opened this issue Mar 13, 2023 · 0 comments
Open
1 task done

Comments

@bendbennett
Copy link
Contributor

bendbennett commented Mar 13, 2023

Terraform CLI and Provider Versions

v2.3.1

Use Cases or Problem Statement

As part of the upgrade to Go 1.19, a workaround was required in order to maintain the current allowed behaviour of using executables that are in the current directory. This has been explicitly prevented with changes to the os/exec package in Go 1.19.

This workaround will be removed in a later version of this provider but prior to that, a warning should be issued to alert practitioners of an impending change in behaviour.

Proposal

Issue a warning when the external provider is executing a program in the current directory. This will require that SkipFunc and more helpful errors for Terraform versions during testing is implemented to allow skipping of Terraform version 0.14 in the tests because TF 0.14 does not write to state if a warning is issued.

How much impact is this issue causing?

Low

Additional Information

Code of Conduct

  • I agree to follow this project's Code of Conduct
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants