Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider Surfacing Null Map Values In Query JSON #209

Open
1 task done
bflad opened this issue Apr 6, 2023 · 0 comments
Open
1 task done

Consider Surfacing Null Map Values In Query JSON #209

bflad opened this issue Apr 6, 2023 · 0 comments

Comments

@bflad
Copy link
Contributor

bflad commented Apr 6, 2023

Terraform CLI and Provider Versions

Terraform v1.4.4
on darwin_arm64

  • provider registry.terraform.io/hashicorp/external v2.3.1

Use Cases or Problem Statement

Upon switching from terraform-plugin-sdk to terraform-plugin-framework, the data available from the query attribute map is now more robust. While the prior SDK completely filtered map keys with null values, the new one properly keeps those map keys with their associated null values. This means the JSON could contain:

"null_map_key": null

However, changing this should be considered a breaking change as programs may not be expecting null JSON values.

Proposal

In the next major version, and if the query is not converted into a generic string type (#17), consider removing any filtering of map keys for null map values and allow those null values to pass through to the query JSON.

How much impact is this issue causing?

Medium

Additional Information

Code of Conduct

  • I agree to follow this project's Code of Conduct
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant