google_logging_project_sink always shows changed if filter has trailing whitespace

[michaelbannister]

I use a HEREDOC string to specify filter for a google_logging_project_sink, which includes a trailing newline.
The value as refreshed from the google API is without a trailing newline, so it always shows as changed.

Affected Resource(s)

Please list the resources as a list, for example:

• google_logging_project_sink

Terraform Configuration Files

resource "google_logging_project_sink" "logs" {
  name = "${local.logging_name}_logs_sink"
  destination = "pubsub.googleapis.com/projects/${data.google_client_config.current.project}/topics/${local.topic_name}"
  filter = <<EOF
resource.type="container"
resource.labels.cluster_name="${var.cluster_name}"
NOT (jsonPayload.wUserAgent="GoogleHC/1.0" OR textPayload:"GoogleHC/1.0" OR jsonPayload.wUserAgent="kube-probe/1.8+"
OR resource.labels.container_name="a" OR resource.labels.container_name="b" OR resource.labels.container_name="c")
EOF
  unique_writer_identity = true
}

Expected Behavior

Upon repeated apply, no change

Actual Behavior

Upon repeated apply,

 ~ module.cluster_logging.google_logging_project_sink.applogs
      filter:     "resource.type=\"container\"\nresource.labels.cluster_name=\"flexi\"\n(resource.labels.container_name=\"a\" OR resource.labels.container_name=\"b\" OR resource.labels.container_name=\"c\")\nNOT (jsonPayload.wUserAgent=\"GoogleHC/1.0\" OR textPayload:\"GoogleHC/1.0\" OR jsonPayload.wUserAgent=\"kube-probe/1.8+\")" => "resource.type=\"container\"\nresource.labels.cluster_name=\"flexi\"\n(resource.labels.container_name=\"a\" OR resource.labels.container_name=\"b\" OR resource.labels.container_name=\"c\")\nNOT (jsonPayload.wUserAgent=\"GoogleHC/1.0\" OR textPayload:\"GoogleHC/1.0\" OR jsonPayload.wUserAgent=\"kube-probe/1.8+\")\n"

References

• Similar to Using "here doc" syntax with datadog_monitor.message causes plan to always show changes terraform#5642 - and a similar solution should work!

[danawillow]

Fixed in #1206

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!