Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add labels parameter for google label on ressource cloudrun service #12194

Closed
mysolo opened this issue Jul 28, 2022 · 2 comments
Closed

add labels parameter for google label on ressource cloudrun service #12194

mysolo opened this issue Jul 28, 2022 · 2 comments

Comments

@mysolo
Copy link

mysolo commented Jul 28, 2022

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment. If the issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If the issue is assigned to a user, that user is claiming responsibility for the issue. If the issue is assigned to "hashibot", a community member has claimed the issue already.

Affected Resource(s)

  • google_cloud_run_service

Description

cloudrun service include a labels in a template/metadata but for kunernetes labels not for a cloudrun service.

i don't check if cloudrun api/sdk permit a adding labels on deploy cloudrun service but a gcloud cli is ok.
gcloud run deploy .

gcloud run deploy --help |grep -i label                                                                                                                                                                                                                                                                                                                                                             git:(master|✚4…1 
        [--clear-labels | --remove-labels=[KEY,...] --labels=[KEY=VALUE,...]
          | --update-labels=[KEY=VALUE,...]]
       --clear-labels
          Remove all labels. If --update-labels is also specified then
          --clear-labels is applied first.
          For example, to remove all labels:
              $ gcloud run deploy --clear-labels
          To remove all existing labels and create two new labels, foo and baz:
              $ gcloud run deploy --clear-labels --update-labels foo=bar,baz=qux
       --remove-labels=[KEY,...]
          List of label keys to remove. If a label does not exist it is
          silently ignored. If --update-labels is also specified then
          --update-labels is applied first.
       --labels=[KEY=VALUE,...]
          List of label KEY=VALUE pairs to add.
          An alias to --update-labels.

Actually use, a provision local-exec. But is only on create ressource. Update a label list is not possible.

Potential Terraform Configuration

resource "google_cloud_run_service" "default" {
  name     = "cloudrun-srv"
  location = "us-central1"

  labels =  {
    env         = "prod"
    owner     = "front"
    folder      = "folder"
    service    = "web"
  }

  template {}

  traffic {
    percent         = 100
    latest_revision = true
  }
}
@rileykarson
Copy link
Collaborator

@github-actions
Copy link

github-actions bot commented Mar 9, 2023

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants