Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

google_cloudbuild_trigger should support disabled option #1952

Closed
anshulpatel25 opened this issue Aug 28, 2018 · 2 comments
Closed

google_cloudbuild_trigger should support disabled option #1952

anshulpatel25 opened this issue Aug 28, 2018 · 2 comments
Labels
enhancement forward/review In review; remove label to forward service/cloudbuild

Comments

@anshulpatel25
Copy link

anshulpatel25 commented Aug 28, 2018

Hello,

google_cloudbuild_trigger should support disabled option upon trigger creation.

Terraform Version

Terraform v0.11.8

Affected Resource(s)

  • google_cloudbuild_trigger

Terraform Configuration Files

provider "google" {
    project = "my-awesome-project"
}

resource "google_cloudbuild_trigger" "trigger" {
    trigger_template {
        branch_name = "master"
        repo_name = "my-awesome-repo"
    }
    build {
        step {
            name = "ubuntu"
            args = "echo Hello World"
        }
    }

    disabled = true
}

Expected Behavior

disabled should be supported.

Actual Behavior

Error: google_cloudbuild_trigger.trigger: : invalid or unknown key: disabled

Steps to Reproduce

terraform plan

@rileykarson
Copy link
Collaborator

Done in #2790. This should land in 2.0.0.

@ghost
Copy link

ghost commented Feb 4, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Feb 4, 2019
@github-actions github-actions bot added service/cloudbuild forward/review In review; remove label to forward labels Jan 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement forward/review In review; remove label to forward service/cloudbuild
Projects
None yet
Development

No branches or pull requests

3 participants