-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update of node_version for container_cluster with seperately defined node_pool(s) fails #397
Update of node_version for container_cluster with seperately defined node_pool(s) fails #397
Comments
I'm not sure if this merits a new/separate issue or not, but I'd love to see the ability to granularly specify version for each node pool independently. Does that seem reasonable? I can potentially give it a shot later today. |
Hey @davidquarles, that sounds like a separate issue. You're welcome to work on it! |
Any progress on this one? We just ran into the same issue. We have a cluster with multiple node pools and we changed the node version. We are fine with updating all node pools (as long as it's done as a rolling upgrade) but this error is preventing us to do anything through Terraform. |
Update: The workaround is to upgrade all the node pools through gcloud cli or web console. |
same for me this day with 1.9.2-gke1 and terraform 0.11.3 |
Hiya is there any progress on this? or a Terraform managed workaround? I'm running terraform v0.11.7 and google provider 1.12.0 |
Thanks for the bump! I haven't gotten around to fixing this yet but it's on my list. |
Actually, implementation question for those of you that want this. Right now we do have the ability to update the version on an individual node pool. If you changed the
|
Hi @danawillow I would have thought that since we have the Would it not be a good idea to allow for the update if both flags are specified or update the error message to specify that |
@danawillow There are two behaviors for this situation that would feel intuitive to me. The first case would be for If you wanted to get fancy with it I could see EDIT: Also had another thought. Perhaps |
Yeah, I think having it apply to node pools defined in the cluster resource that don't otherwise have a version set (including the default node pool) makes sense. I won't be able to actually get started on this until next week at the earliest, so if anyone else catches this and has an opinion before I start the work, feel free to continue sharing :) |
I always have this error with:
|
I have tested to remove
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
Terraform Version
Terraform v0.10.4
Terraform-provider-google v0.1.3
Affected Resource(s)
Description
If you have a google_container_cluster with a node pool added through a google_container_node_pool resource and you change the node_version on the google_container_cluster, a 'terraform apply' will start an upgrade, which fails, because it does not specify which node pool it wants to upgrade.
Terraform Configuration Files
https://gist.github.com/drzero42/ebc14c702b2f10572fcd70354110fd03
Steps to Reproduce
Error message
The text was updated successfully, but these errors were encountered: