Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

google_container_cluster auto_provisioning_defaults state never converges #5442

Closed
MaT1g3R opened this issue Jan 20, 2020 · 5 comments · Fixed by GoogleCloudPlatform/magic-modules#3019
Assignees
Labels
bug forward/review In review; remove label to forward service/container

Comments

@MaT1g3R
Copy link

MaT1g3R commented Jan 20, 2020

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request.
  • Please do not leave +1 or me too comments, they generate extra noise for issue followers and do not help prioritize the request.
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment.
  • If an issue is assigned to the modular-magician user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If an issue is assigned to a user, that user is claiming responsibility for the issue. If an issue is assigned to hashibot, a community member has claimed the issue already.

Terraform Version

v0.12.18

Affected Resource(s)

  • google_container_cluster

Terraform Configuration Files

resource "google_container_cluster" "default-cluster" {
  provider = google-beta

  name = local.cluster_name

  cluster_autoscaling {
    enabled = true
    resource_limits {
      resource_type = "cpu"
      minimum       = 6
      maximum       = 72
    }
    resource_limits {
      resource_type = "memory"
      minimum       = 24
      maximum       = 128
    }
    auto_provisioning_defaults {
      service_account = google_service_account.k8s_service_account.email
    }
  }
}

Expected Behavior

Terraform state does not track oauth_scopes under auto_provisioning_defaults

Actual Behavior

Terraform state tracks oauth_scopes under auto_provisioning_defaults, which leads to a diff for every apply like so:

~ cluster_autoscaling {
    enabled = true
    ~ auto_provisioning_defaults {
        ~ oauth_scopes    = [
            - "https://www.googleapis.com/auth/logging.write",
            - "https://www.googleapis.com/auth/monitoring",
        ]
        service_account = "xxxx@xxxx.iam.gserviceaccount.com"
    }
    resource_limits {
        maximum       = 72
        minimum       = 6
        resource_type = "cpu"
    }
    resource_limits {
        maximum       = 128
        minimum       = 24
        resource_type = "memory"
    }
}

Steps to Reproduce

  1. terraform apply
@ghost ghost added the bug label Jan 20, 2020
@edwardmedia
Copy link
Contributor

edwardmedia commented Jan 22, 2020

@MaT1g3R yes, I can repro this issue. It does show below plan after initial apply

Plan: 0 to add, 1 to change, 0 to destroy.

@mtricolici
Copy link

This issue is still present in latest terraform version 0.12.20 !

@mtricolici
Copy link

/reopen

@danawillow
Copy link
Contributor

Hi @mtricolici, we close issues once the code is checked in, but that doesn't mean it's been released yet. You can see whether or not a given PR has made it into a release by checking the CHANGELOG.

Note also that 0.12.20 is a Terraform CLI version but not a Google Provider version. You can read about provider versions at https://www.terraform.io/docs/configuration/providers.html#provider-versions.

@ghost
Copy link

ghost commented Mar 28, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 28, 2020
@github-actions github-actions bot added service/container forward/review In review; remove label to forward labels Jan 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug forward/review In review; remove label to forward service/container
Projects
None yet
5 participants