Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource/kubernetes_persistent_volume_claim: Improve event log polling for warns #125

Merged
merged 1 commit into from
Feb 26, 2018
Merged

resource/kubernetes_persistent_volume_claim: Improve event log polling for warns #125

merged 1 commit into from
Feb 26, 2018

Conversation

radeksimko
Copy link
Member

Sometimes relevant warnings are those where PV is involvedObject so I expanded the filtering here.

Before

=== RUN   TestAccKubernetesPersistentVolumeClaim_googleCloud_volumeMatch
--- FAIL: TestAccKubernetesPersistentVolumeClaim_googleCloud_volumeMatch (329.04s)
	testing.go:449: Step 0 error: Error applying: 1 error(s) occurred:

		* kubernetes_persistent_volume_claim.test: 1 error(s) occurred:

		* kubernetes_persistent_volume_claim.test: timeout while waiting for state to become 'Bound' (last state: 'Pending', timeout: 5m0s)

After

=== RUN   TestAccKubernetesPersistentVolumeClaim_googleCloud_volumeMatch
--- FAIL: TestAccKubernetesPersistentVolumeClaim_googleCloud_volumeMatch (328.78s)
	testing.go:449: Step 0 error: Error applying: 1 error(s) occurred:

		* kubernetes_persistent_volume_claim.test: 1 error(s) occurred:

		* kubernetes_persistent_volume_claim.test: timeout while waiting for state to become 'Bound' (last state: 'Pending', timeout: 5m0s)
		   * tf-acc-test-qqeeb844y9 (PersistentVolume): VolumeMismatch: Volume's size is smaller than requested or volume's class does not match with claim

@radeksimko radeksimko requested a review from a team February 26, 2018 12:59
@radeksimko radeksimko merged commit 66901c4 into master Feb 26, 2018
@radeksimko radeksimko deleted the f-pvc-improve-event-polling branch February 26, 2018 17:40
@radeksimko radeksimko mentioned this pull request Mar 2, 2018
Closed
@ghost ghost locked and limited conversation to collaborators Apr 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@paddycarver paddycarver paddycarver approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@radeksimko @paddycarver