Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/kubernetes_pod: Add timeout to pod resource #151

Merged
merged 2 commits into from
Apr 9, 2018
Merged

r/kubernetes_pod: Add timeout to pod resource #151

merged 2 commits into from
Apr 9, 2018

Conversation

appilon
Copy link
Contributor

@appilon appilon commented Apr 5, 2018

Fix #91

Configurable timeouts for Create and Delete (plumbing was already in place). Let me know if we want to support more timeouts (read, update) or just address the ones described in the issue.

@appilon appilon changed the title resource/kubernetes_pod: Add timeout to pod resource r/kubernetes_pod: Add timeout to pod resource Apr 5, 2018
Copy link

@catsby catsby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately the Timeouts isn't automagical, you need to reference them in the code spots that should use them

Update: schema.DefaultTimeout(5 * time.Minute),
Delete: schema.DefaultTimeout(5 * time.Minute),
Default: schema.DefaultTimeout(5 * time.Minute),
},
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

womp womp. Thank you for the links I was wondering how it worked.

Copy link
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@appilon appilon merged commit ea3b56c into hashicorp:master Apr 9, 2018
@ghost ghost locked and limited conversation to collaborators Apr 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kubernetes_pod timeout
3 participants