Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 1322: allow_volume_expansion fix #1519

Conversation

AnisimoffNikita
Copy link
Contributor

Description

Acceptance tests

  • Have you added an acceptance test for the functionality being added?
  • Have you run the acceptance tests on this branch?

Output from acceptance testing:

$ KUBE_CONFIG_PATH='~/.kube/config' make testacc TESTARGS='-run=TestAccKubernetesStorageClass_volumeExpansion' 
==> Checking that code complies with gofmt requirements...
go vet .
rm -rf /Users/<username>/work/terraform-provider-kubernetes/kubernetes/test-infra/external-providers/.terraform /Users/<username>/work/terraform-provider-kubernetes/kubernetes/test-infra/external-providers/.terraform.lock.hcl || true
mkdir /Users/<username>/work/terraform-provider-kubernetes/kubernetes/test-infra/external-providers/.terraform
mkdir -p /tmp/.terraform.d/localhost/test/kubernetes/9.9.9/darwin_amd64 || true
ls /tmp/.terraform.d/localhost/test/kubernetes/9.9.9/darwin_amd64/terraform-provider-kubernetes_9.9.9_darwin_amd64 || go build -o /tmp/.terraform.d/localhost/test/kubernetes/9.9.9/darwin_amd64/terraform-provider-kubernetes_9.9.9_darwin_amd64
ls: /tmp/.terraform.d/localhost/test/kubernetes/9.9.9/darwin_amd64/terraform-provider-kubernetes_9.9.9_darwin_amd64: No such file or directory
cd /Users/<username>/work/terraform-provider-kubernetes/kubernetes/test-infra/external-providers && TF_CLI_CONFIG_FILE=/Users/<username>/work/terraform-provider-kubernetes/kubernetes/test-infra/external-providers/.terraformrc TF_PLUGIN_CACHE_DIR=/Users/<username>/work/terraform-provider-kubernetes/kubernetes/test-infra/external-providers/.terraform terraform init -upgrade

Initializing the backend...

Initializing provider plugins...
- Finding localhost/test/kubernetes versions matching "9.9.9"...
- Installing localhost/test/kubernetes v9.9.9...
- Installed localhost/test/kubernetes v9.9.9 (unauthenticated)

Terraform has created a lock file .terraform.lock.hcl to record the provider
selections it made above. Include this file in your version control repository
so that Terraform can guarantee to make the same selections by default when
you run "terraform init" in the future.

Terraform has been successfully initialized!

You may now begin working with Terraform. Try running "terraform plan" to see
any changes that are required for your infrastructure. All Terraform commands
should now work.

If you ever set or change modules or backend configuration for Terraform,
rerun this command to reinitialize your working directory. If you forget, other
commands will detect it and remind you to do so if necessary.
TF_CLI_CONFIG_FILE=/Users/<username>/work/terraform-provider-kubernetes/kubernetes/test-infra/external-providers/.terraformrc TF_PLUGIN_CACHE_DIR=/Users/<username>/work/terraform-provider-kubernetes/kubernetes/test-infra/external-providers/.terraform TF_ACC=1 go test "/Users/<username>/work/terraform-provider-kubernetes/kubernetes" -v -run=TestAccKubernetesStorageClass_volumeExpansion -timeout 120m
=== RUN   TestAccKubernetesStorageClass_volumeExpansion
--- PASS: TestAccKubernetesStorageClass_volumeExpansion (6.06s)
PASS
ok      github.com/hashicorp/terraform-provider-kubernetes/kubernetes   6.585s

Release Note

Release note for CHANGELOG:

Fix allow_volume_expansion toggle

References

resolves #1322

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

@hashicorp-cla
Copy link

hashicorp-cla commented Nov 30, 2021

CLA assistant check
All committers have signed the CLA.

@BBBmau BBBmau requested a review from a team as a code owner January 23, 2023 20:38
Copy link
Member

@alexsomesan alexsomesan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this, @AnisimoffNikita!
Long over-due review, but the changes look good.

Thanks for the re-base and re-testing this, @BBBmau!

@BBBmau BBBmau merged commit c9182af into hashicorp:main Jan 23, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Toggling 'allow_volume_expansion' on 'storage_class' resources have no effect
4 participants