Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/kubernetes_pod: env var value change forces new pod #155

Merged
merged 1 commit into from
Apr 17, 2018
Merged

r/kubernetes_pod: env var value change forces new pod #155

merged 1 commit into from
Apr 17, 2018

Conversation

appilon
Copy link
Contributor

@appilon appilon commented Apr 17, 2018

Fix #98

add forcenew on env var value field
add acc test

@appilon appilon requested a review from a team April 17, 2018 21:20
Copy link

@paddycarver paddycarver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

func TestAccKubernetesPod_updateEnvForceNew(t *testing.T) {
var conf api.Pod

podName := fmt.Sprintf("tf-acc-test-%s", acctest.RandStringFromCharSet(10, acctest.CharSetAlphaNum))

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you could use RandString here, I don't think you need to specify the charset, but I could be wrong.

@appilon appilon merged commit 2d09dbf into hashicorp:master Apr 17, 2018
@ghost ghost locked and limited conversation to collaborators Apr 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Updating environment variables has no effect because pod is not recreated
2 participants