Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TK-1898] Update 'service(_v1)' resource documentation #1856

Merged
merged 1 commit into from
Oct 6, 2022

Conversation

arybolovlev
Copy link
Contributor

@arybolovlev arybolovlev commented Oct 5, 2022

Description

This PR makes spec.port block optional in the documentation to align with the schema and the provider behavior. The spec.port is optional in the case when spec.type is ExternalName.

Release Note

r/kubernetes_service: make `spec.port` block optional
r/kubernetes_service_v1: make `spec.port` block optional

References

Fix: #1851

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

@arybolovlev arybolovlev changed the title Update 'service(_v1)' resource documentation [TK-1898] Update 'service(_v1)' resource documentation Oct 5, 2022
@arybolovlev arybolovlev marked this pull request as ready for review October 5, 2022 09:48
@alexsomesan alexsomesan merged commit 8d1950d into main Oct 6, 2022
@alexsomesan alexsomesan deleted the update-service-doc branch October 6, 2022 15:39
@github-actions
Copy link

github-actions bot commented Nov 7, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid Kubernetes Service resource validates, but should not validate
3 participants